Skip to content

fix: 🏷️ Fix incorrect view rtypes#2940

Merged
Lulalaby merged 1 commit into
masterfrom
fix/views-typehints
Oct 20, 2025
Merged

fix: 🏷️ Fix incorrect view rtypes#2940
Lulalaby merged 1 commit into
masterfrom
fix/views-typehints

Conversation

@Paillat-dev

Copy link
Copy Markdown
Member

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev
Paillat-dev requested a review from a team as a code owner September 21, 2025 13:53
@pycord-app

pycord-app Bot commented Sep 21, 2025

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2940/head:pr-2940
git checkout pr-2940

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2940/head

@Icebluewolf Icebluewolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View.remove_item and View.clear_items have the same problem. Also, you need to add the return type to the docs.

@Lulalaby
Lulalaby merged commit e27ff1d into master Oct 20, 2025
27 of 28 checks passed
@Lulalaby
Lulalaby deleted the fix/views-typehints branch October 20, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants