feat: ✨ Allow for functools.partial and functions returning an awaitable as autocomplete#2914
Merged
Conversation
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
Paillat-dev
requested review from
DA-344,
JustaSqu1d,
Lulalaby and
NeloBlivion
September 5, 2025 11:31
Signed-off-by: Lala Sabathil <[email protected]>
Lulalaby
requested review from
NeloBlivion and
Soheab
and removed request for
DA-344,
JustaSqu1d,
Lumabots,
NeloBlivion and
Soheab
October 20, 2025 10:15
Lulalaby
enabled auto-merge (squash)
October 20, 2025 10:16
Lulalaby
disabled auto-merge
October 20, 2025 10:16
3 tasks
Member
|
conflicts~ |
Member
Author
|
sowwy, needs testing anyways tho I think |
Signed-off-by: Paillat <[email protected]>
Lulalaby
approved these changes
Oct 20, 2025
Paillat-dev
added a commit
to Pycord-Development/pycord-next
that referenced
this pull request
Oct 26, 2025
…table as autocomplete (Pycord-Development#2914) * ✨ Allow for `functools.partials` and such as autocomplete * 📝 CHANGELOG.md * 🏷️ Better typing * 🚚 Add partial autocomplete example * 🩹 Make CI pass * 📝 Move docstring to getter * 🏷️ Boring typing stuff * ✏️ Fix writing * chore: 👽 Update base max filesize to `10` Mb (Pycord-Development#2671) * 👽 Update base max filesize to `10` Mb * 📝 CHANGELOG.md * 📝 Requested changes * 📝 Grammar * ♻️ Merge the 2 examples * ⚰️ remove conflicting autocomplete attribute from `Option` * 🐛 Fix missing setting autocomplete * Copilot Signed-off-by: Paillat <[email protected]> * 📝 CHANGELOG.md Signed-off-by: Paillat <[email protected]> * Update CHANGELOG.md Signed-off-by: Paillat <[email protected]> * 📝 Update CHANGELOG.md * 🐛 Missing description kwarg in autocomplete example --------- Signed-off-by: Paillat <[email protected]> Signed-off-by: Paillat <[email protected]> Signed-off-by: Paillat <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> (cherry picked from commit b190b7f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows usage of functions with any number of optional parameters as autocomplete. This allows by extent the usage of partials and similar as autocomplete.
Fixes #2668
Superseeds #2669
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.