fix: Unbound raw reference in parse_message_update#2905
Merged
Conversation
raw reference in parse_message_update
raw reference in parse_message_updateraw reference in parse_message_update
Member
|
Changelog pls |
Paillat-dev
reviewed
Sep 3, 2025
Signed-off-by: Paillat <[email protected]>
Paillat-dev
approved these changes
Sep 3, 2025
DA-344
approved these changes
Sep 3, 2025
Member
|
Lulalaby
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Here’s a nicely formatted PR draft you can use for your change 👇
📖 Description
This PR fixes an issue in the
parse_message_updatemethod where the variablerawwas being referenced before assignment when retrievingold_message.Previously, the method tried to access
raw.message_idbeforerawwas defined, causing an unbound variable error.Now, the method correctly retrieves the message ID directly from
data["id"]before creating theRawMessageUpdateEvent.🔧 Changes Made
old_messageretrieval to useint(data["id"])instead ofraw.message_id.rawis created after bothold_messageand the newMessageobject are initialized.raw_message_edit,message_edit, poll handling, and component tracking).✅ Why This Fix Matters
rawvariable.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.