feat: redo CV2 and New Modal implementation#2904
Merged
Merged
Conversation
plun1331
reviewed
Sep 3, 2025
Member
Author
|
changing this to a general feature pr teehee |
Soheab
reviewed
Sep 18, 2025
Paillat-dev
reviewed
Oct 19, 2025
Paillat-dev
previously approved these changes
Oct 20, 2025
Paillat-dev
left a comment
Member
There was a problem hiding this comment.
Conflicts. Lgtm other than that
Signed-off-by: Nelo <[email protected]>
Paillat-dev
previously approved these changes
Oct 20, 2025
Signed-off-by: Paillat <[email protected]>
Paillat-dev
previously approved these changes
Oct 20, 2025
Member
|
Could use one more approving review additionally to needing Lala imo maybe @Lumabots if you wanna take a look ? |
Contributor
If it's ready I can take a look at that tonight |
Member
|
I'll take a proper look on this after I've slept. |
Lulalaby
reviewed
Oct 21, 2025
Signed-off-by: Lala Sabathil <[email protected]>
Lulalaby
approved these changes
Oct 21, 2025
Member
Author
|
thankuuu |
3 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewandModalnow only support original components (Button/Select,InputText) - assume behavior from <=2.6.1DesignerViewandDesignerModal(names not finalised idk)DesignerViewandContainerdo not supportButton,@button,Selectand@selectdirectly; useActionRowinstead.Sectionstill supportsButtonas accessory and thebuttondecoratorDesignerModaldoes not supportInputTextandSelectdirectly; useLabelinstead.TextDisplaystill works as a top-level component.InputText.description,Select.labelandSelect.descriptionare removed as they are part of theLabelcomponentDesignerViewcan still be used for v1 messages (supportingcontentandembeds) if you want to migrate toActionRowfor any reason.ActionRowto aViewwill add the row's children insteadItemhas been split intoViewItemandModalItemInputTextandLabelnow inheritModalItemViewItemSelectandTextDisplayinherit bothViewItemandModalItem(even thoughSelectis not a top-level modal item, i believe it still fits)storeparameter toItemInterface; setting it toFalsewill prevent the interface from being added toViewStore/ModalStore, and as such will not trigger callbacks or refresh item states.Webhook.parent(interaction that created the webhook) andWebhook.from_interactionInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.