Skip to content

fix: usage of SlashCommandOptionType since its a subclass of tuple#2901

Merged
Lulalaby merged 13 commits into
Pycord-Development:masterfrom
Lumabots:optional-option
Sep 1, 2025
Merged

fix: usage of SlashCommandOptionType since its a subclass of tuple#2901
Lulalaby merged 13 commits into
Pycord-Development:masterfrom
Lumabots:optional-option

Conversation

@Lumabots

@Lumabots Lumabots commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lumabots and others added 11 commits August 3, 2025 22:01
@Lumabots
Lumabots requested review from a team as code owners September 1, 2025 20:48
@pullapprove4
pullapprove4 Bot requested a review from Dorukyum September 1, 2025 20:48
@Paillat-dev

Paillat-dev commented Sep 1, 2025

Copy link
Copy Markdown
Member

@Lumabots You're 31 commits behind

@Lumabots Lumabots changed the title fix usage of SlashCommandOptionType since its a subclass of tuple fix: usage of SlashCommandOptionType since its a subclass of tuple Sep 1, 2025
@Lumabots
Lumabots marked this pull request as draft September 1, 2025 21:02
@Lumabots

Lumabots commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

pl

@Lumabots You're 31 commits behind

ur a goat

@Lumabots
Lumabots marked this pull request as ready for review September 1, 2025 21:04
@Lulalaby

Lulalaby commented Sep 1, 2025

Copy link
Copy Markdown
Member

So.. are we good now?

@Lumabots

Lumabots commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

So.. are we good now?

yeah we should, i mean i only return because else its considered weirdly as a tuple...

@Lulalaby
Lulalaby merged commit 9443985 into Pycord-Development:master Sep 1, 2025
28 checks passed
Paillat-dev pushed a commit to Pycord-Development/pycord-next that referenced this pull request Oct 9, 2025
@Lulalaby @Paillat-dev
fix: usage of SlashCommandOptionType since its a subclass of tuple (P…
22461a2 
…ycord-Development#2901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes
@NeloBlivion NeloBlivion Awaiting requested review from NeloBlivion NeloBlivion was automatically assigned from Pycord-Development/library-maintainers
@Paillat-dev Paillat-dev Awaiting requested review from Paillat-dev Paillat-dev was automatically assigned from Pycord-Development/library-maintainers
@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d JustaSqu1d was automatically assigned from Pycord-Development/library-contributors
@DA-344 DA-344 Awaiting requested review from DA-344 DA-344 was automatically assigned from Pycord-Development/library-contributors
@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lumabots @Paillat-dev @Lulalaby