Skip to content

fix: 🐛 handle None case for default_reaction_emoji in ForumChannel edit payload#2739

Merged
Lulalaby merged 2 commits into
Pycord-Development:masterfrom
Paillat-dev:fix/forum-edit-no-default-emojis
Mar 19, 2025
Merged

fix: 🐛 handle None case for default_reaction_emoji in ForumChannel edit payload#2739
Lulalaby merged 2 commits into
Pycord-Development:masterfrom
Paillat-dev:fix/forum-edit-no-default-emojis

Conversation

@Paillat-dev

@Paillat-dev Paillat-dev commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev
Paillat-dev force-pushed the fix/forum-edit-no-default-emojis branch from 728cec2 to 647fa21 Compare March 18, 2025 20:23
@Paillat-dev Paillat-dev changed the title 🐛 handle None case for default_reaction_emoji in reaction payload fix: 🐛 handle None case for default_reaction_emoji in reaction payload Mar 18, 2025
@Paillat-dev Paillat-dev changed the title fix: 🐛 handle None case for default_reaction_emoji in reaction payload fix: 🐛 handle None case for default_reaction_emoji in ForumChannel edit payload Mar 18, 2025
@Paillat-dev
Paillat-dev force-pushed the fix/forum-edit-no-default-emojis branch from 647fa21 to f3af9e0 Compare March 19, 2025 10:30
@Paillat-dev
Paillat-dev marked this pull request as ready for review March 19, 2025 10:33
@Paillat-dev
Paillat-dev requested a review from a team as a code owner March 19, 2025 10:33
@pullapprove4
pullapprove4 Bot requested a review from Lulalaby March 19, 2025 10:33
@Lulalaby
Lulalaby force-pushed the fix/forum-edit-no-default-emojis branch from c25a870 to 8b5fcf0 Compare March 19, 2025 17:31
@Lulalaby
Lulalaby enabled auto-merge (squash) March 19, 2025 17:31
@Lulalaby
Lulalaby merged commit 92cdfea into Pycord-Development:master Mar 19, 2025
@Paillat-dev
Paillat-dev deleted the fix/forum-edit-no-default-emojis branch March 19, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Paillat-dev @Lulalaby