Skip to content

fix: raise intended exception for ephemeral paginator with >=15min timeout#2718

Merged
Lulalaby merged 1 commit into
Pycord-Development:masterfrom
fiskenslakt:fix-ephemeral-paginator-timeout
Feb 24, 2025
Merged

fix: raise intended exception for ephemeral paginator with >=15min timeout#2718
Lulalaby merged 1 commit into
Pycord-Development:masterfrom
fiskenslakt:fix-ephemeral-paginator-timeout

Conversation

@fiskenslakt

@fiskenslakt fiskenslakt commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Summary

If a paginator has a timeout of 15min or more and is set to be ephemeral, the intended exception notifying the user they can't do that fails to get raised because it attempts to compare None with int.

Example traceback:

Traceback (most recent call last):
  File "/Users/derek/Code/pzsd-bot/.venv/lib/python3.12/site-packages/discord/commands/core.py", line 138, in wrapped
    ret = await coro(arg)
          ^^^^^^^^^^^^^^^
  File "/Users/derek/Code/pzsd-bot/.venv/lib/python3.12/site-packages/discord/commands/core.py", line 1078, in _invoke
    await self.callback(self.cog, ctx, **kwargs)
  File "/Users/derek/Code/pzsd-bot/pzsd_bot/cogs/points/admin.py", line 178, in users
    await paginator.respond(ctx.interaction, ephemeral=True)
  File "/Users/derek/Code/pzsd-bot/.venv/lib/python3.12/site-packages/discord/ext/pages/pagination.py", line 1155, in respond
    if ephemeral and (self.timeout >= 900 or self.timeout is None):
                      ^^^^^^^^^^^^^^^^^^^
TypeError: '>=' not supported between instances of 'NoneType' and 'int'

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@fiskenslakt
fiskenslakt requested a review from a team as a code owner February 24, 2025 09:19
@pullapprove4
pullapprove4 Bot requested a review from Dorukyum February 24, 2025 09:19
Paillat-dev
Paillat-dev approved these changes Feb 24, 2025
View reviewed changes

@Paillat-dev Paillat-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pr, lgtm for all it's worth.

@Lulalaby
Lulalaby enabled auto-merge (squash) February 24, 2025 10:20
@Lulalaby
Lulalaby merged commit a145bcd into Pycord-Development:master Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes
@Paillat-dev Paillat-dev Paillat-dev approved these changes
@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fiskenslakt @Lulalaby @Paillat-dev