Skip to content

fix: Allow renewal_sku_ids To Handle None#2709

Merged
Lulalaby merged 3 commits into
Pycord-Development:masterfrom
Icebluewolf:subscription-update-response-handling
Feb 6, 2025
Merged

fix: Allow renewal_sku_ids To Handle None#2709
Lulalaby merged 3 commits into
Pycord-Development:masterfrom
Icebluewolf:subscription-update-response-handling

Conversation

@Icebluewolf

Copy link
Copy Markdown
Member

Summary

Discord states renewal_sku_ids is nullable. We were treating it if it was always a list.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby
Lulalaby merged commit 36ba89d into Pycord-Development:master Feb 6, 2025
@Lulalaby

Lulalaby commented Feb 6, 2025

Copy link
Copy Markdown
Member

Thanks, merged

Comment thread CHANGELOG.md
@Icebluewolf
Icebluewolf deleted the subscription-update-response-handling branch February 6, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants