refactor: Rewrite the role tags mess#2708
Conversation
20d75bb to
696dcbf
Compare
plun1331
left a comment
There was a problem hiding this comment.
This looks really easy to make backwards compatible, can we just do that and deprecate all the compatibility methods?
|
Yeah maybe i'll try, but it sucks when I reused method names to become properties |
|
What are your thoughts on adding something like an enum, e.g. |
|
As we previously talked on dcs, the role type enum is the best way. Like plun said, deprecated all current methods and just create the type on role. But the docs should clarify that it's calculated since it's not returned by discord |
0c18960 to
7e7d40e
Compare
7e7d40e to
5810fa3
Compare
27a15ee to
54f1baa
Compare
|
Here is a handy snippet for testing this: import logging
import os
from datetime import datetime, UTC
from dotenv import load_dotenv
import discord
load_dotenv()
logging.basicConfig(level=logging.DEBUG)
TOKEN = os.getenv("TOKEN_3")
bot = discord.Bot()
@bot.slash_command()
async def test_roles(ctx: discord.ApplicationContext, role: discord.Role):
await ctx.defer()
if not ctx.guild:
return await ctx.respond("This command must be used in a guild.")
fetched_role = await ctx.guild.fetch_role(role.id)
await ctx.respond(f"""```
Role:
{role!r}
Role tags:
{role.tags!r}
Role tags data:
{role.tags._data if role.tags else None}
Fetched role:
{fetched_role!r}
Fetched role tags:
{fetched_role.tags!r}
Fetched role tags data:
{fetched_role.tags._data if fetched_role.tags else None}
```""")
bot.run(TOKEN) |
|
Do not merge yet |
d030f17 to
c27c52d
Compare
3e162b1 to
cab1fe7
Compare
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
|
the fuck did i do |
|
So, it's too late to be non-breaking now, but all other enums in pycord are lowercase while the enum created here is uppercase. |
|
Uppercase is more idiomatic because they are constants, so it's not that bad. I personally think we should make all of them uppercase, and deprecate the lowercase ones but it's a discussion for another time & place. |

Summary
Rewrite the role tags mess.

Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.