fix: reset exponential backoff after task runs successfully in tasks extension#2700
Merged
Merged
Conversation
JustaSqu1d
requested changes
Jan 24, 2025
JustaSqu1d
added
priority: medium
Lulalaby
approved these changes
Jan 25, 2025
The current behaviour of the _loop method (when the reconnect attribute is set to True) is to have the same ExponentialBackoff instance for all of its lifetime. A task that has failed n times over its life-time will thus wait 2**n seconds before retrying, no matter how many successful instances of happened between the failures. With this commit, the behaviour is to reset the exponential backoff after a succesful execution of the task, so that the backoff only takes place after successive failures.
Signed-off-by: DaBlumer <[email protected]>
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DaBlumer <[email protected]>
Lulalaby
force-pushed
the
fix-tasks-backoff
branch
from
January 25, 2025 23:11
c5001d1 to
606e15a
Compare
Lulalaby
enabled auto-merge (squash)
January 25, 2025 23:11
Paillat-dev
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2698
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.