fix: Fixed Attachment Metadata Being Set Incorrectly In Interaction Responses#2679
Merged
Dorukyum merged 6 commits intoDec 28, 2024
Conversation
plun1331
added
bug
plun1331
previously approved these changes
Dec 27, 2024
plun1331
enabled auto-merge (squash)
December 27, 2024 08:29
JustaSqu1d
requested changes
Dec 27, 2024
JustaSqu1d
left a comment
JustaSqu1d
left a comment
Member
There was a problem hiding this comment.
slightly ambiguous wording fix
Member
It could be interpreted as the "interaction responses" being ignored as opposed to the "attachment metadata" |
Member
I hadn't realised that but your suggestion wouldn't solve it |
Signed-off-by: Ice Wolfy <[email protected]>
auto-merge was automatically disabled
December 27, 2024 17:08
Head branch was pushed to by a user without write access
3 tasks
Member
Author
|
Don't merge yet |
Dorukyum
requested changes
Dec 28, 2024
Member
Author
|
Should Be Fixed
|
Dorukyum
force-pushed
the
interaction_attachment_metadata
branch
from
December 28, 2024 20:10
2f3ab42 to
88503b7
Compare
Dorukyum
enabled auto-merge (squash)
December 28, 2024 20:12
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
approved these changes
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In interaction responses attachment metadata was being placed in the wrong spot in the request body causing discord to ignore it.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.