feat: Add helper methods to determine interactions integrations by DA-344 · Pull Request #2659 · Pycord-Development/pycord

DA-344 · 2024-11-28T15:45:46Z

Summary

Adds Interaction.is_guild_integration and Interaction.is_user_integration to easily check whether an interaction has been invoked by a guild or user integration.

Also adds this to ApplicationContext.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

Lulalaby

Good addition! 💕🎉

Paillat-dev

👍

JustaSqu1d

minor convention and grammar

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

JustaSqu1d

I don't quite like the naming. Interactions aren't exactly integrations.

Could we change it from is_x_integration to is_x_authorized?

Or if you have a better name that we could go with.

DA-344 · 2024-12-15T14:57:06Z

I don't quite like the naming. Interactions aren't exactly integrations.

Yeah, but when invoking an application command, you are using an integration, which can either be guild or user installed.

Could we change it from is_x_integration to is_x_authorized?

Or if you have a better name that we could go with.

I think the current naming is nice, but if it is really neccesary I can change it to is_x_authorized.

Paillat-dev · 2024-12-15T15:04:28Z

I feel like both namings make sense, maybe is_x_authorized is more explicit since that is in fact what is being checked.

…into feat/interaction-integrations-methods

* 👽 Update base max filesize to `10` Mb * 📝 CHANGELOG.md

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

…ycord-Development#2676) Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.13.0...v1.14.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ations-methods

Signed-off-by: plun1331 <[email protected]>

JustaSqu1d

For some reason changelog is en-US.

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

Lulalaby

we really should stop doing american / british english

Add is_..._integration helper methods

1e549e8

DA-344 requested a review from a team as a code owner November 28, 2024 15:45

pullapprove4 Bot requested a review from VincentRPS November 28, 2024 15:45

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Nov 28, 2024

chore: Update changelog

0d09f96

Lulalaby previously approved these changes Nov 28, 2024

View reviewed changes

pullapprove4 Bot removed the PA: Maintainers pending label Nov 28, 2024

Lulalaby enabled auto-merge (squash) November 28, 2024 16:03

Lulalaby requested review from JustaSqu1d and plun1331 and removed request for VincentRPS November 28, 2024 16:03

Lulalaby added the feature Implements a feature label Nov 28, 2024

Lulalaby added this to the v2.7 milestone Nov 28, 2024

Paillat-dev approved these changes Nov 28, 2024

View reviewed changes

Merge branch 'master' into feat/interaction-integrations-methods

d63403e

JustaSqu1d requested changes Dec 10, 2024

View reviewed changes

Comment thread discord/commands/context.py Outdated

Comment thread discord/interactions.py Outdated

Comment thread CHANGELOG.md Outdated

pullapprove4 Bot removed the PA: All Contributors pending label Dec 10, 2024

chore: Update with suggestions

053bc06

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

auto-merge was automatically disabled December 10, 2024 07:44
Head branch was pushed to by a user without write access

DA-344 dismissed Lulalaby’s stale review via 053bc06 December 10, 2024 07:44

pullapprove4 Bot added the PA: Maintainers pending label Dec 10, 2024

JustaSqu1d requested a review from Lulalaby December 10, 2024 07:44

DA-344 and others added 2 commits December 10, 2024 08:46

chore: Update discord/commands/context.py

ddee02b

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

chore: Update discord/interactions.py

80ceb6d

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

JustaSqu1d requested changes Dec 10, 2024

View reviewed changes

DA-344 added 2 commits December 15, 2024 16:08

Merge branch 'master' of https://github.com/Pycord-Development/pycord …

6feb46f

…into feat/interaction-integrations-methods

chore: Rename is_x_integration to is_x_authorised/authorized

5ded3fe

DA-344 and others added 4 commits December 18, 2024 17:51

Merge branch 'master' of https://github.com/Pycord-Development/pycord …

112a69f

…into feat/interaction-integrations-methods

chore: 👽 Update base max filesize to 10 Mb (Pycord-Development#2671)

8dd4b4f

* 👽 Update base max filesize to `10` Mb * 📝 CHANGELOG.md

chore: Update docstrings to mention aliases

df0dd91

chore: Update CHANGELOG.md

ff2f1b7

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

DA-344 requested a review from JustaSqu1d December 18, 2024 16:58

pullapprove4 Bot added the PA: All Contributors pending label Dec 18, 2024

dependabot Bot and others added 2 commits December 21, 2024 00:44

Merge branch 'Pycord-Development:master' into feat/interaction-integr…

cf04e3e

…ations-methods

Lulalaby force-pushed the master branch from 041ea16 to 7f5a23f Compare December 24, 2024 09:24

Merge branch 'master' into feat/interaction-integrations-methods

556d06a

Signed-off-by: plun1331 <[email protected]>

plun1331 reviewed Dec 25, 2024

View reviewed changes

Comment thread CHANGELOG.md Outdated

Update CHANGELOG.md

dfa89fe

Signed-off-by: plun1331 <[email protected]>

plun1331 enabled auto-merge (squash) December 26, 2024 18:26

plun1331 previously approved these changes Dec 26, 2024

View reviewed changes

pullapprove4 Bot removed the PA: Maintainers pending label Dec 26, 2024

Merge branch 'master' into feat/interaction-integrations-methods

317fcef

JustaSqu1d requested changes Dec 27, 2024

View reviewed changes

Comment thread CHANGELOG.md Outdated

pullapprove4 Bot removed the PA: All Contributors pending label Dec 27, 2024

chore: authorising -> authorizing (who commited this tf)

9edbb55

Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: DA344 <[email protected]>

auto-merge was automatically disabled December 27, 2024 08:41
Head branch was pushed to by a user without write access

DA-344 dismissed plun1331’s stale review via 9edbb55 December 27, 2024 08:41

pullapprove4 Bot added the PA: Maintainers pending label Dec 27, 2024

JustaSqu1d approved these changes Dec 27, 2024

View reviewed changes

pullapprove4 Bot added the PA: All Contributors pending label Dec 27, 2024

Merge branch 'master' into feat/interaction-integrations-methods

c7ca029

Dorukyum approved these changes Dec 27, 2024

View reviewed changes

pullapprove4 Bot removed PA: All Contributors pending PA: Maintainers pending labels Dec 27, 2024

Lulalaby approved these changes Dec 27, 2024

View reviewed changes

Lulalaby merged commit 9fa5cbe into Pycord-Development:master Dec 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: Add helper methods to determine interactions integrations#2659

feat: Add helper methods to determine interactions integrations#2659
Lulalaby merged 19 commits into
Pycord-Development:masterfrom
DA-344:feat/interaction-integrations-methods

DA-344 commented Nov 28, 2024

Uh oh!

Lulalaby left a comment

Uh oh!

Paillat-dev left a comment

Uh oh!

JustaSqu1d left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JustaSqu1d left a comment •

edited

Loading

Uh oh!

DA-344 commented Dec 15, 2024

Uh oh!

Paillat-dev commented Dec 15, 2024

Uh oh!

Uh oh!

JustaSqu1d left a comment

Uh oh!

Uh oh!

Lulalaby left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

DA-344 commented Nov 28, 2024

Summary

Information

Checklist

Uh oh!

Lulalaby left a comment

Choose a reason for hiding this comment

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

JustaSqu1d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JustaSqu1d left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DA-344 commented Dec 15, 2024

Uh oh!

Paillat-dev commented Dec 15, 2024

Uh oh!

Uh oh!

JustaSqu1d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lulalaby left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JustaSqu1d left a comment •

edited

Loading