Skip to content

fix: 🐛 Fix duplicate bridge cmds in default help cmd#2656

Merged
Lulalaby merged 6 commits into
Pycord-Development:masterfrom
Paillat-dev:fix-help-duplicate-cmds
Jan 28, 2025
Merged

fix: 🐛 Fix duplicate bridge cmds in default help cmd#2656
Lulalaby merged 6 commits into
Pycord-Development:masterfrom
Paillat-dev:fix-help-duplicate-cmds

Conversation

@Paillat-dev

@Paillat-dev Paillat-dev commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Fixes: #2306
Closes: #2415
Alternative to: #2415 (stale imo)
If you prefer waiting for #2415 I don't mind, just made a quick fix here because that pr seemed dead.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • [~] I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev
Paillat-dev requested a review from a team as a code owner November 27, 2024 13:24
@pullapprove4
pullapprove4 Bot requested a review from plun1331 November 27, 2024 13:24
Lulalaby
Lulalaby previously approved these changes Nov 27, 2024
View reviewed changes
@Lulalaby
Lulalaby enabled auto-merge (squash) November 27, 2024 14:03
@Paillat-dev

Paillat-dev commented Dec 5, 2024

Copy link
Copy Markdown
Member Author

Please don't merge this yet I thought of something I want to test first.

@Paillat-dev
Paillat-dev disabled auto-merge December 5, 2024 22:12
@Lulalaby
Lulalaby dismissed their stale review December 5, 2024 22:31

Author's wish

@Paillat-dev

Paillat-dev commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

Ok I fixed a small issue there.

@Paillat-dev
Paillat-dev requested a review from Lulalaby December 9, 2024 10:44
@Paillat-dev

Paillat-dev commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

In any case, the code for this help command is reeeally messed up ngl

Lulalaby
Lulalaby approved these changes Dec 9, 2024
View reviewed changes

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like me fr

Dorukyum
Dorukyum reviewed Dec 26, 2024
View reviewed changes
Comment thread discord/ext/commands/help.py
@Dorukyum Dorukyum mentioned this pull request Jan 5, 2025
Closed
9 tasks
@Dorukyum
Dorukyum requested review from Dorukyum and removed request for plun1331 January 14, 2025 15:21
plun1331
plun1331 previously approved these changes Jan 28, 2025
View reviewed changes
Lulalaby
Lulalaby previously approved these changes Jan 28, 2025
View reviewed changes
@Lulalaby
Lulalaby enabled auto-merge (squash) January 28, 2025 18:18
@Lulalaby
Lulalaby requested a review from plun1331 January 28, 2025 18:18
@Lulalaby

Lulalaby commented Jan 28, 2025

Copy link
Copy Markdown
Member

@plun1331 new review pls

@Lulalaby
Lulalaby merged commit aa13d82 into Pycord-Development:master Jan 28, 2025
@Paillat-dev
Paillat-dev deleted the fix-help-duplicate-cmds branch January 29, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes
@plun1331 plun1331 plun1331 approved these changes
@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Command duplication in cog help

4 participants

@Paillat-dev @Lulalaby @plun1331 @Dorukyum