Skip to content

refactor: ♻️ Use typing_extensions instead of _typed_dict#2621

Merged
Dorukyum merged 6 commits into
Pycord-Development:masterfrom
Paillat-dev:typed-dict
Jan 5, 2025
Merged

refactor: ♻️ Use typing_extensions instead of _typed_dict#2621
Dorukyum merged 6 commits into
Pycord-Development:masterfrom
Paillat-dev:typed-dict

Conversation

@Paillat-dev

@Paillat-dev Paillat-dev commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Information

  • This PR fixes an issue.
    fixes: Remove _typed_dict.py #2166
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev
Paillat-dev requested a review from a team as a code owner October 24, 2024 12:44
@pullapprove4
pullapprove4 Bot requested a review from VincentRPS October 24, 2024 12:44
@Paillat-dev Paillat-dev changed the title core: ♻️ Use typing_extensions instead of _typed_dict chore: ♻️ Use typing_extensions instead of _typed_dict Oct 24, 2024
@Paillat-dev Paillat-dev changed the title chore: ♻️ Use typing_extensions instead of _typed_dict refactor: ♻️ Use typing_extensions instead of _typed_dict Oct 24, 2024
@Paillat-dev

Paillat-dev commented Oct 24, 2024

Copy link
Copy Markdown
Member Author

Does this need changelog ?

@Paillat-dev Paillat-dev mentioned this pull request Oct 28, 2024
Merged
9 tasks
@plun1331 plun1331 added priority: low Low Priority status: awaiting review Awaiting review from a maintainer dependencies Pull requests that update a dependency file labels Oct 29, 2024
@Dorukyum

Dorukyum commented Nov 11, 2024

Copy link
Copy Markdown
Member

Does this need changelog ?

Nope, just need to test if this works for typing_extensions 4.0.0 since that's the lowest allowed version in the requirements.

@Paillat-dev

Paillat-dev commented Nov 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

image
image
It does work, I will test again and merge master in here

@Dorukyum

Dorukyum commented Nov 18, 2024

Copy link
Copy Markdown
Member

TypedDict has had changes after 4.0.0 (ref), we'd better test both older and newer versions.

@Paillat-dev

Paillat-dev commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

will do

@Paillat-dev

Paillat-dev commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

#2655 requires 4.5.0 at least. Do I test from that up ?

@Dorukyum

Dorukyum commented Jan 4, 2025

Copy link
Copy Markdown
Member

#2655 requires 4.5.0 at least. Do I test from that up ?

Two seperate pull requests, no need.

Dorukyum
Dorukyum reviewed Jan 4, 2025
View reviewed changes
Comment thread requirements/_.txt
@Dorukyum
Dorukyum enabled auto-merge (squash) January 4, 2025 18:47
Lulalaby
Lulalaby approved these changes Jan 5, 2025
View reviewed changes

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well here we go

@Dorukyum
Dorukyum merged commit f0c8e53 into Pycord-Development:master Jan 5, 2025
@Paillat-dev
Paillat-dev deleted the typed-dict branch March 10, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes
@Dorukyum Dorukyum Dorukyum approved these changes
@VincentRPS VincentRPS Awaiting requested review from VincentRPS

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove _typed_dict.py

4 participants

@Paillat-dev @Dorukyum @Lulalaby @plun1331