Skip to content

feat: ✨ New role tags#2606

Merged
Lulalaby merged 13 commits into
Pycord-Development:masterfrom
Paillat-dev:fix-is-integration
Jan 7, 2025
Merged

feat: ✨ New role tags#2606
Lulalaby merged 13 commits into
Pycord-Development:masterfrom
Paillat-dev:fix-is-integration

Conversation

@Paillat-dev

@Paillat-dev Paillat-dev commented Oct 11, 2024 •
edited by Dorukyum
Loading

Copy link
Copy Markdown
Member

Summary

fixes: #2474
cc @Lumabots

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev
Paillat-dev requested a review from a team as a code owner October 11, 2024 10:03
@pullapprove4
pullapprove4 Bot requested a review from FrostByte266 October 11, 2024 10:03
@Paillat-dev Paillat-dev changed the title 🩹 Fix Role.is_integration() Fix 🩹 Role.is_integration() Oct 11, 2024
@Paillat-dev Paillat-dev changed the title Fix 🩹 Role.is_integration() fix: 🩹 Role.is_integration() Oct 11, 2024
@Lulalaby

Lulalaby commented Oct 11, 2024

Copy link
Copy Markdown
Member

Changelog

@Paillat-dev
Paillat-dev force-pushed the fix-is-integration branch 2 times, most recently from 9270a61 to fb32e22 Compare October 11, 2024 16:06
@Paillat-dev

Paillat-dev commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

There. Maybe discord.RoleTags.is_integration() should be removed too ? That would be breaking tho.

@plun1331

plun1331 commented Oct 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

is_integration is for roles managed by integrations, such as patreon/twitch
is_bot_managed is for roles assigned to bots when added to a server by discord
is_premium_subscriber is for the server booster role managed by discord
managed is True if any of the above is True

In my testing, with this logic, is_integration works just fine and was never broken.
This should really be a documentation update, as the docs are misleading.

@Lulalaby

Lulalaby commented Oct 11, 2024

Copy link
Copy Markdown
Member

Do we cover the new tags also? Like for role subscription, server shop, etc

@plun1331

plun1331 commented Oct 11, 2024

Copy link
Copy Markdown
Member

Do we cover the new tags also? Like for role subscription, server shop, etc

We do not, missing subscription_listing_id, available_for_purchase, guild_connections

@Lulalaby

Lulalaby commented Oct 11, 2024

Copy link
Copy Markdown
Member

https://gist.github.com/Lulalaby/a9ac5fcce5c182efd55167e6141c1542
As little help

@Paillat-dev

Paillat-dev commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

Yeah that was a documentation issue. I will change that instead.

@Paillat-dev
Paillat-dev marked this pull request as draft October 11, 2024 20:17
@plun1331 plun1331 added documentation Improvements or additions to documentation priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature API reflection Discord API isn't correctly reflected and removed on hold labels Oct 11, 2024
@plun1331 plun1331 added this to the v2.7 milestone Oct 11, 2024
@Paillat-dev

Paillat-dev commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

@plun1331 I might add the other tags too now that i'm here.

@plun1331

plun1331 commented Oct 11, 2024

Copy link
Copy Markdown
Member

Go for it, shouldn't be too difficult

@plun1331

plun1331 commented Nov 2, 2024

Copy link
Copy Markdown
Member

I like keeping a clean history

makes it harder to see what you changed, and it all gets squashed anyways

JustaSqu1d
JustaSqu1d requested changes Dec 12, 2024
View reviewed changes

@JustaSqu1d JustaSqu1d left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar stuff

Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Comment thread CHANGELOG.md Outdated
JustaSqu1d
JustaSqu1d requested changes Dec 17, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Dorukyum
Dorukyum reviewed Jan 4, 2025
View reviewed changes
Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Comment thread discord/role.py Outdated
Comment thread CHANGELOG.md Outdated
@Paillat-dev
Paillat-dev requested a review from Dorukyum January 6, 2025 08:01
Lulalaby
Lulalaby approved these changes Jan 7, 2025
View reviewed changes

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Paillat-dev

@Lulalaby
Lulalaby merged commit 8d8fb2b into Pycord-Development:master Jan 7, 2025
@Paillat-dev
Paillat-dev deleted the fix-is-integration branch January 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes
@Dorukyum Dorukyum Dorukyum approved these changes
@plun1331 plun1331 plun1331 left review comments
@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees

@Lulalaby Lulalaby

@Dorukyum Dorukyum

Labels

API reflection Discord API isn't correctly reflected documentation Improvements or additions to documentation feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess

Projects

None yet

Milestone

v2.7

Development

Successfully merging this pull request may close these issues.

is_integration return False even if its an integration

5 participants

@Paillat-dev @Lulalaby @plun1331 @Dorukyum @JustaSqu1d