fix: Send correct data to http.create_test_entitlement()#2595
Merged
Conversation
Signed-off-by: lukenamop <[email protected]>
Signed-off-by: lukenamop <[email protected]>
Signed-off-by: lukenamop <[email protected]>
Contributor
Author
|
create_test_entitlement is currently completely broken, the deadline for bots with paying customers to implement entitlements is coming up in 4 days (October 7). Would love for this fix to be implemented before then. |
Dorukyum
reviewed
Oct 4, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: lukenamop <[email protected]>
Signed-off-by: lukenamop <[email protected]>
plun1331
reviewed
Oct 4, 2024
Signed-off-by: plun1331 <[email protected]>
Contributor
Author
|
I've got my production bot running on this fork. Working as intended. Thanks for help with changelog formatting. |
Dorukyum
approved these changes
Oct 4, 2024
plun1331
enabled auto-merge (squash)
October 4, 2024 20:39
plun1331
approved these changes
Oct 4, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
…lopment#2595) * Update guild.py Signed-off-by: lukenamop <[email protected]> * Update user.py Signed-off-by: lukenamop <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Signed-off-by: lukenamop <[email protected]> * Update CHANGELOG.md Co-authored-by: Dorukyum <[email protected]> Signed-off-by: lukenamop <[email protected]> * Update CHANGELOG.md Signed-off-by: lukenamop <[email protected]> * Update CHANGELOG.md Signed-off-by: plun1331 <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: lukenamop <[email protected]> Signed-off-by: plun1331 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: plun1331 <[email protected]>
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
…lopment#2595) * Update guild.py Signed-off-by: lukenamop <[email protected]> * Update user.py Signed-off-by: lukenamop <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Signed-off-by: lukenamop <[email protected]> * Update CHANGELOG.md Co-authored-by: Dorukyum <[email protected]> Signed-off-by: lukenamop <[email protected]> * Update CHANGELOG.md Signed-off-by: lukenamop <[email protected]> * Update CHANGELOG.md Signed-off-by: plun1331 <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: lukenamop <[email protected]> Signed-off-by: plun1331 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: plun1331 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.create_test_entitlement() asks for (application_id, payload). Previously, guild.create_test_entitlement() was sending (guild_id, payload) and user.create_test_entitlement() was sending (user_id, payload). I've fixed them to send the correct data.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.