feat: Add function to get elapsed time of playing audio on VoiceClient#2587
Merged
Lulalaby merged 14 commits intoOct 11, 2024
Merged
Conversation
felix920506
changed the title
Member
|
Seconds seem really inflexible, what if we returned a |
Contributor
Author
|
Sounds reasonable |
Contributor
Author
|
Can I have a review on this? |
Dorukyum
reviewed
Oct 4, 2024
Contributor
Author
|
Changed to use loops + an offset to keep track of when loops gets reset |
Dorukyum
reviewed
Oct 11, 2024
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
requested changes
Oct 11, 2024
Dorukyum
left a comment
Dorukyum
left a comment
Member
There was a problem hiding this comment.
I find client.elapsed() to be clearer and simpler, what do you think?
Contributor
Author
|
I don't have any preference between client.elapsed() or client.played_time() |
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: felix920506 <[email protected]>
Dorukyum
approved these changes
Oct 11, 2024
Lulalaby
approved these changes
Oct 11, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
Pycord-Development#2587) * add played_seconds function * Update CHANGELOG.md * style(pre-commit): auto fixes from pre-commit.com hooks * use datetime.timedelta instead of int * add comment * style(pre-commit): auto fixes from pre-commit.com hooks * rename function to reflect change * style(pre-commit): auto fixes from pre-commit.com hooks * don't use different counter * Update discord/voice_client.py Signed-off-by: Dorukyum <[email protected]> * Apply suggestions from code review Co-authored-by: Dorukyum <[email protected]> Signed-off-by: felix920506 <[email protected]> --------- Signed-off-by: felix920506 <[email protected]> Signed-off-by: Dorukyum <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
Pycord-Development#2587) * add played_seconds function * Update CHANGELOG.md * style(pre-commit): auto fixes from pre-commit.com hooks * use datetime.timedelta instead of int * add comment * style(pre-commit): auto fixes from pre-commit.com hooks * rename function to reflect change * style(pre-commit): auto fixes from pre-commit.com hooks * don't use different counter * Update discord/voice_client.py Signed-off-by: Dorukyum <[email protected]> * Apply suggestions from code review Co-authored-by: Dorukyum <[email protected]> Signed-off-by: felix920506 <[email protected]> --------- Signed-off-by: felix920506 <[email protected]> Signed-off-by: Dorukyum <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a function to get the elapsed seconds of currently playing audio file
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.