fix: Single Member Enums Fail Converting To Option#2577
Merged
Lulalaby merged 8 commits intoSep 16, 2024
Conversation
3 tasks
Dorukyum
reviewed
Sep 16, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Ice Wolfy <[email protected]>
Lulalaby
enabled auto-merge (squash)
September 16, 2024 16:01
Lulalaby
approved these changes
Sep 16, 2024
Dorukyum
approved these changes
Sep 16, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
…t#2577) * fix: Check If Enum Has Docstring Before Using It As Option Description * fix: Single Item Enums Of Invalid Types Not Converting To String * chore: Update Changelog * style(pre-commit): auto fixes from pre-commit.com hooks * chore: I Used The Wrong PR Number * Update discord/commands/options.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Ice Wolfy <[email protected]> --------- Signed-off-by: Ice Wolfy <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
…t#2577) * fix: Check If Enum Has Docstring Before Using It As Option Description * fix: Single Item Enums Of Invalid Types Not Converting To String * chore: Update Changelog * style(pre-commit): auto fixes from pre-commit.com hooks * chore: I Used The Wrong PR Number * Update discord/commands/options.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Ice Wolfy <[email protected]> --------- Signed-off-by: Ice Wolfy <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where a Enum with one member that is not of a type accepted by discord an error would be thrown during option conversion.
It also solves #2558
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.