Skip to content

feat: subscriptions & related changes#2564

Merged
plun1331 merged 31 commits into
masterfrom
feat/subscriptions
Jan 31, 2025
Merged

feat: subscriptions & related changes#2564
plun1331 merged 31 commits into
masterfrom
feat/subscriptions

Conversation

@plun1331

@plun1331 plun1331 commented Aug 28, 2024

Copy link
Copy Markdown
Member

Summary

https://discord.com/developers/docs/change-log#premium-apps-entitlement-migration-and-new-subscription-api

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 added bug Something isn't working documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Aug 28, 2024
@plun1331 plun1331 added this to the v2.7 milestone Aug 28, 2024
@plun1331 plun1331 self-assigned this Aug 28, 2024
@plun1331
plun1331 requested a review from a team as a code owner August 28, 2024 22:20
@plun1331

Copy link
Copy Markdown
Member Author

Untested (because i can't)

Comment thread discord/enums.py Outdated
Signed-off-by: Lala Sabathil <[email protected]>
@Lulalaby

Lulalaby commented Aug 28, 2024

Copy link
Copy Markdown
Member

@plun1331 if u want to test it lmk, i have a few apps with monitization ready u could use
tho these changes are being made in future, not sure if we should test it rn

@plun1331

Copy link
Copy Markdown
Member Author

@Lulalaby review when available please :3

@Lulalaby

Copy link
Copy Markdown
Member

i'm still down with illness

@plun1331
plun1331 requested a review from Dorukyum October 2, 2024 18:10
@JustaSqu1d
JustaSqu1d requested review from Lulalaby and removed request for Lulalaby October 25, 2024 18:09
@DA-344

DA-344 commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

This now requires the new changes from discord/discord-api-docs#7304 , just a new field.

@Lulalaby

Copy link
Copy Markdown
Member

If you mean the country field, as noted by discord, it's only available through a private oauth scope. So I'm not sure if it's needed 😅

@DA-344

DA-344 commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

I meant the renewal_sku_ids field 😅

@Lulalaby

Lulalaby commented Dec 12, 2024

Copy link
Copy Markdown
Member

Oop. Missed that. I only proof-readed the discord pr 😅

@Dorukyum

Dorukyum commented Jan 5, 2025

Copy link
Copy Markdown
Member

@plun1331 update please.

@plun1331
plun1331 disabled auto-merge January 31, 2025 20:37
@plun1331
plun1331 merged commit beeef7d into master Jan 31, 2025
@plun1331
plun1331 deleted the feat/subscriptions branch January 31, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants