Skip to content

fix: incorrect type-hint for RawMemberRemoveEvent.user#2456

Closed
yoggys wants to merge 4 commits into
Pycord-Development:masterfrom
yoggys:RawMemberRemoveEvent-type-hinting
Closed

fix: incorrect type-hint for RawMemberRemoveEvent.user#2456
yoggys wants to merge 4 commits into
Pycord-Development:masterfrom
yoggys:RawMemberRemoveEvent-type-hinting

Conversation

@yoggys

@yoggys yoggys commented May 16, 2024

Copy link
Copy Markdown
Contributor

Summary

Fixed the type-hinting of RawMemberRemoveEvent.user to reflect actual behavior.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Comment thread CHANGELOG.md Outdated
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: YoggieS <[email protected]>
@yoggys
yoggys requested a review from plun1331 May 17, 2024 07:44
@plun1331 plun1331 changed the title fix: RawMemberRemoveEvent type-hinting fix: incorrect type-hint for RawMemberRemoveEvent.user May 17, 2024
@plun1331
plun1331 enabled auto-merge (squash) May 17, 2024 13:12
@plun1331 plun1331 added bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels May 17, 2024
@plun1331 plun1331 added this to the v2.6 milestone May 17, 2024
@plun1331

Copy link
Copy Markdown
Member

Superseded by #2457

@plun1331 plun1331 closed this May 18, 2024
auto-merge was automatically disabled May 18, 2024 04:06

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants