feat: Support bulk banning in guilds#2421
Conversation
plun1331
left a comment
There was a problem hiding this comment.
Possibly make a new method instead (guild.bulk_ban) since they're different endpoints, and similar stuff is split as well (e.g. fetch_member vs fetch_members)
Co-authored-by: plun1331 <[email protected]> Signed-off-by: UK <[email protected]>
I did consider this initially, but after mulling it over I figured it made more sense to compare to |
My main issue is we end up having multiple different return types, which isn't a massive problem but might be confusing as some people might pass a list and not expect it to give |
|
I agree with plun, a new method should suffice. |
|
Upon implementing it myself I agree with doru, a seperate method is needed |
Lulalaby
left a comment
There was a problem hiding this comment.
Revert changes and introduce bulk banning as new method bulk_ban.
Also we should finally remove delete message days
|
With this, 2.6 is officially breaking so please include the relevant warnings in any announcements |
|
Before we merge it, @Dorukyum, do you agree on removing the obsolete parameter completely in this PR? |
It's fine. A seperate pr for each change would obviously be better, but the changes here are relevant enough I guess. |
Summary
Guild.bannow accepts up to 200 membersCurrently, this returns two lists:
Alternatively, we could have a new
GuildBulkBanobject with attributesbannedandfailedInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.