feat: implement Guild.search_members#2418
Merged
Merged
Conversation
Blue-Robin-Taken
approved these changes
Apr 9, 2024
Contributor
|
haven't tested this yet but I will soon |
Member
|
Search Guild Members doesn't appear to be paginated, so you shouldn't need an iterator |
plun1331
approved these changes
Apr 11, 2024
JustaSqu1d
approved these changes
Apr 11, 2024
Dorukyum
reviewed
Apr 16, 2024
| ---------- | ||
| query: :class:`str` | ||
| Searches for usernames and nicknames that start with this string, case-insensitive. | ||
| limit: Optional[:class:`int`] |
Member
There was a problem hiding this comment.
This shouldn't have been Optional, it doesn't support None.
plun1331
added a commit
to SkyKings-Guild/pycord
that referenced
this pull request
Apr 21, 2024
* feat: add once kwarg to Cog.listener (Pycord-Development#2403) * add once kwarg to Cog.listener * clarify * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <[email protected]> * chore(pre-commit): pre-commit autoupdate (Pycord-Development#2410) updates: - [github.com/asottile/pyupgrade: v3.15.1 → v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: pass proper state to interaction._guild (Pycord-Development#2411) * fix: option and BridgeOption adjustments (Pycord-Development#2417) * chore(pre-commit): pre-commit autoupdate (Pycord-Development#2416) updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: implement Guild.search_members (Pycord-Development#2418) * implement guild member search * clarification. * style(pre-commit): auto fixes from pre-commit.com hooks * cl * undo iteration * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(deps): bump ribtoks/tdg-github-action from 0.4.7.pre.beta to 0.4.10.pre.beta (Pycord-Development#2420) ci(deps): bump ribtoks/tdg-github-action Bumps [ribtoks/tdg-github-action](https://github.com/ribtoks/tdg-github-action) from 0.4.7.pre.beta to 0.4.10.pre.beta. - [Release notes](https://github.com/ribtoks/tdg-github-action/releases) - [Commits](ribtoks/tdg-github-action@v0.4.7-beta...v0.4.10-beta) --- updated-dependencies: - dependency-name: ribtoks/tdg-github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: plun1331 <[email protected]> * fix: Added member data to the raw_reaction_remove event (Pycord-Development#2412) * fix: Added member data to the raw_reaction_remove event * style(pre-commit): auto fixes from pre-commit.com hooks * Added changelog.md for adding member data to raw reaction remove * Update CHANGELOG.md Signed-off-by: plun1331 <[email protected]> * doc: Updated documentation for the RawReactionActionEvent.member field --------- Signed-off-by: plun1331 <[email protected]> Co-authored-by: root <root@DESKTOP-U7KGUE3> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <[email protected]> * chore(pre-commit): pre-commit autoupdate (Pycord-Development#2422) updates: - [github.com/psf/black: 24.3.0 → 24.4.0](psf/black@24.3.0...24.4.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * docs: remove false optional (Pycord-Development#2424) docs: not optional * fix: Guild.query_members may accept empty query and limit (Pycord-Development#2419) Signed-off-by: UK <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <[email protected]> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: plun1331 <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: plun1331 <[email protected]> Signed-off-by: UK <[email protected]> Co-authored-by: UK <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jordan-day <[email protected]> Co-authored-by: root <root@DESKTOP-U7KGUE3> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: JustaSqu1d <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
...Apparently, this was never implemented
Uses the existing MemberIterator with some modifications to support query.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.