Skip to content

fix: Duplication in bridge command help#2415

Closed
Blue-Robin-Taken wants to merge 14 commits into
Pycord-Development:masterfrom
Blue-Robin-Taken:master
Closed

fix: Duplication in bridge command help#2415
Blue-Robin-Taken wants to merge 14 commits into
Pycord-Development:masterfrom
Blue-Robin-Taken:master

Conversation

@Blue-Robin-Taken

@Blue-Robin-Taken Blue-Robin-Taken commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

Summary

This pull request is for the issue #2306

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Blue-Robin-Taken
Blue-Robin-Taken requested a review from a team as a code owner April 5, 2024 13:06
@Blue-Robin-Taken
Blue-Robin-Taken marked this pull request as draft April 5, 2024 13:06
@pullapprove4
pullapprove4 Bot requested a review from BobDotCom April 5, 2024 13:06
@Blue-Robin-Taken
Update CHANGELOG.md
270bf96 
Signed-off-by: BlueRobin <[email protected]>
@Blue-Robin-Taken
Blue-Robin-Taken marked this pull request as ready for review April 5, 2024 15:37
Lulalaby
Lulalaby previously approved these changes Apr 6, 2024
View reviewed changes
@Lulalaby
Lulalaby enabled auto-merge (squash) April 6, 2024 17:22
@Lulalaby
Lulalaby requested review from Dorukyum and JustaSqu1d and removed request for BobDotCom April 6, 2024 17:23
JustaSqu1d
JustaSqu1d requested changes Apr 9, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread discord/ext/commands/help.py Outdated
@Blue-Robin-Taken
Use case for same group
f4c943f 
Signed-off-by: BlueRobin <[email protected]>
auto-merge was automatically disabled April 9, 2024 20:22

Head branch was pushed to by a user without write access

@Blue-Robin-Taken

Blue-Robin-Taken commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

I haven't checked if the code works yet but I will when I get home

@plun1331 plun1331 linked an issue Apr 12, 2024 that may be closed by this pull request
Command duplication in cog help #2306
Closed
3 tasks
@plun1331 plun1331 added the bug Something isn't working label Apr 12, 2024
@plun1331

plun1331 commented May 6, 2024

Copy link
Copy Markdown
Member

I haven't checked if the code works yet but I will when I get home

Any updates?

@Blue-Robin-Taken

Blue-Robin-Taken commented May 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for the reminder, I currently do not have time atm to check it still 💀
finals are coming up and I might be able to check tomorrow

sorry

@Blue-Robin-Taken

Blue-Robin-Taken commented May 17, 2024

Copy link
Copy Markdown
Contributor Author

I'm definitely going to wait to do this after final exams or maybe if I have time this weekend

JustaSqu1d
JustaSqu1d reviewed Aug 7, 2024
View reviewed changes
Comment thread CHANGELOG.md
- Fixed invalid data being passed to `Interaction._guild` in certain cases.
([#2411](https://github.com/Pycord-Development/pycord/pull/2411))
- Fixed `BridgeCommand` duplication in default help commands.
([#2415](https://github.com/Pycord-Development/pycord/pull/2415))

@JustaSqu1d JustaSqu1d Aug 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move changelog to new section

@Lulalaby

Lulalaby commented Aug 10, 2024

Copy link
Copy Markdown
Member

@Blue-Robin-Taken

@Lulalaby Lulalaby added this to the v2.7 milestone Aug 10, 2024
@Blue-Robin-Taken

Blue-Robin-Taken commented Aug 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I just started junior year of HS and if I have time today (cause it's the weekend) I'll get on it
Thanks for the notifs @Lulalaby !

@Lulalaby

Lulalaby commented Aug 10, 2024

Copy link
Copy Markdown
Member

Thanks, ping me when ready to review

@ChickenDevs

ChickenDevs commented Sep 10, 2024

Copy link
Copy Markdown
Member

@Blue-Robin-Taken Just wanted to follow up on this PR!

@Paillat-dev Paillat-dev mentioned this pull request Nov 27, 2024
Merged
8 tasks
@Dorukyum

Dorukyum commented Jan 5, 2025

Copy link
Copy Markdown
Member

Stale, superseded by #2656.

@Dorukyum Dorukyum closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d requested changes
@Dorukyum Dorukyum Awaiting requested review from Dorukyum
@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

v2.7

Development

Successfully merging this pull request may close these issues.

Command duplication in cog help

6 participants

@Blue-Robin-Taken @plun1331 @Lulalaby @ChickenDevs @Dorukyum @JustaSqu1d