Skip to content

fix: type-hinting in ScheduledEvent.subscribers#2400

Merged
Dorukyum merged 13 commits into
Pycord-Development:masterfrom
yoggys:scheduled-event-typing
Mar 22, 2024
Merged

fix: type-hinting in ScheduledEvent.subscribers#2400
Dorukyum merged 13 commits into
Pycord-Development:masterfrom
yoggys:scheduled-event-typing

Conversation

@yoggys

@yoggys yoggys commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

Summary

Fixed type-hinting for ScheduledEvent.subscribers parameter limit: Optional[:class:int]

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@yoggys yoggys changed the title fix: hint-typing in ScheduledEvent.subscribers fix: type-hinting in ScheduledEvent.subscribers Mar 19, 2024
@yoggys

yoggys commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

ahaha wrong title

Comment thread discord/iterators.py Outdated
@yoggys
yoggys requested a review from plun1331 March 20, 2024 23:00
plun1331
plun1331 previously approved these changes Mar 21, 2024
@plun1331
plun1331 enabled auto-merge (squash) March 21, 2024 00:14
@plun1331 plun1331 added this to the v2.6 milestone Mar 21, 2024
Comment thread CHANGELOG.md Outdated
Comment thread discord/iterators.py
Signed-off-by: YoggieS <[email protected]>
auto-merge was automatically disabled March 21, 2024 19:46

Head branch was pushed to by a user without write access

@yoggys
yoggys requested a review from Dorukyum March 21, 2024 19:49
@Dorukyum
Dorukyum enabled auto-merge (squash) March 22, 2024 09:08
@Dorukyum
Dorukyum merged commit a29bc14 into Pycord-Development:master Mar 22, 2024
@yoggys
yoggys deleted the scheduled-event-typing branch March 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants