Skip to content

feat: add banner to ClientUser.edit#2396

Merged
Lulalaby merged 9 commits into
Pycord-Development:masterfrom
Braandn:master
Mar 17, 2024
Merged

feat: add banner to ClientUser.edit#2396
Lulalaby merged 9 commits into
Pycord-Development:masterfrom
Braandn:master

Conversation

@Braandn

@Braandn Braandn commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Added "banner" to the edit function.

Till now the official discord docs are not updated, but its is working.

ref: discord/discord-api-docs#6710

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Added "banner" to the edit function.

Till now the official discord docs are not updated, but the code is working.

ref: discord/discord-api-docs#6710

Signed-off-by: Brandon <[email protected]>
@JustaSqu1d JustaSqu1d added the hold: changelog This pull request is missing a changelog entry label Mar 15, 2024

@plun1331 plun1331 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

Comment thread discord/user.py Outdated
Comment thread discord/user.py
@plun1331 plun1331 changed the title Ability to change/set the banner of the bot. feat: add banner to ClientUser.edit Mar 16, 2024
Comment thread discord/user.py Outdated
Signed-off-by: plun1331 <[email protected]>

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

@plun1331
plun1331 enabled auto-merge (squash) March 17, 2024 07:12
@plun1331
plun1331 requested a review from Lulalaby March 17, 2024 07:13
@Lulalaby
Lulalaby disabled auto-merge March 17, 2024 07:52
@Lulalaby
Lulalaby enabled auto-merge (squash) March 17, 2024 07:53
@Lulalaby
Lulalaby merged commit 530f3d4 into Pycord-Development:master Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold: changelog This pull request is missing a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants