Skip to content

feat: retry http requests that fail with a 503 status#2395

Merged
Lulalaby merged 7 commits into
Pycord-Development:masterfrom
D4rk-S0ul:auto-restart-on-503
Mar 22, 2024
Merged

feat: retry http requests that fail with a 503 status#2395
Lulalaby merged 7 commits into
Pycord-Development:masterfrom
D4rk-S0ul:auto-restart-on-503

Conversation

@D4rk-S0ul

@D4rk-S0ul D4rk-S0ul commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Added the 503 status code to the retry-mechanism as a (temporary) solution for Discord's frequent server issues lately.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@D4rk-S0ul
D4rk-S0ul requested a review from a team as a code owner March 15, 2024 17:19
@pullapprove4
pullapprove4 Bot requested a review from Middledot March 15, 2024 17:19
@pullapprove4
pullapprove4 Bot requested a review from FrostByte266 March 15, 2024 17:19
@Lulalaby
Lulalaby force-pushed the auto-restart-on-503 branch from 12e4c67 to 1e6e9a7 Compare March 17, 2024 01:56
@plun1331 plun1331 added status: awaiting review Awaiting review from a maintainer feature Implements a feature hold: changelog This pull request is missing a changelog entry labels Mar 18, 2024
plun1331
plun1331 previously requested changes Mar 18, 2024
View reviewed changes

@plun1331 plun1331 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog please :)

@plun1331 plun1331 changed the title fix: Auto-Restart on 503 Status Code feat: retry http requests that fail with a 503 status Mar 18, 2024
plun1331
plun1331 reviewed Mar 19, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
@plun1331 plun1331 removed the hold: changelog This pull request is missing a changelog entry label Mar 20, 2024
@Dorukyum
Dorukyum requested a review from Lulalaby March 21, 2024 04:55
@Lulalaby
Lulalaby enabled auto-merge (squash) March 21, 2024 05:17
@Lulalaby
Lulalaby requested review from Dorukyum and removed request for FrostByte266 and Middledot March 21, 2024 05:17
@Lulalaby
Lulalaby merged commit 532db98 into Pycord-Development:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plun1331 plun1331 plun1331 left review comments
@Lulalaby Lulalaby Lulalaby approved these changes
@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes
@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

No one assigned

Labels

feature Implements a feature status: awaiting review Awaiting review from a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@D4rk-S0ul @Lulalaby @plun1331 @JustaSqu1d