Skip to content

feat: Change type of Guild.bitrate_limit to int.#2387

Merged
Lulalaby merged 4 commits into
Pycord-Development:masterfrom
yoggys:bitrate_limit_type
Mar 8, 2024
Merged

feat: Change type of Guild.bitrate_limit to int.#2387
Lulalaby merged 4 commits into
Pycord-Development:masterfrom
yoggys:bitrate_limit_type

Conversation

@yoggys

@yoggys yoggys commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Summary

Changed Guild.bitrate_limit to return an int for consistent application flow as it is expected e.g. when creating voice channels.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
@Lulalaby
Lulalaby requested review from Dorukyum and JustaSqu1d and removed request for CodeWithSwastik March 8, 2024 00:13
@Lulalaby
Lulalaby enabled auto-merge (squash) March 8, 2024 00:13
Signed-off-by: Lala Sabathil <[email protected]>
Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
Comment thread CHANGELOG.md Outdated
Signed-off-by: plun1331 <[email protected]>
@Lulalaby
Lulalaby merged commit 9b1c86c into Pycord-Development:master Mar 8, 2024
@yoggys
yoggys deleted the bitrate_limit_type branch March 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants