Skip to content

fix(ext.bridge/commands): default arguments with Option don't work#2256

Merged
Dorukyum merged 5 commits into
masterfrom
fix-2089
Nov 29, 2023
Merged

fix(ext.bridge/commands): default arguments with Option don't work#2256
Dorukyum merged 5 commits into
masterfrom
fix-2089

Conversation

@Middledot

Copy link
Copy Markdown
Member

Summary

Fix #2089
Bridge commands that use discord.Option don't have their default values or "required" attributes recognized by ext.commands.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Comment thread discord/ext/commands/core.py Outdated
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Middledot <[email protected]>
Dorukyum
Dorukyum previously approved these changes Nov 29, 2023
@Dorukyum
Dorukyum enabled auto-merge (squash) November 29, 2023 17:32
@Dorukyum
Dorukyum merged commit a7f4adb into master Nov 29, 2023
@Dorukyum
Dorukyum deleted the fix-2089 branch January 21, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent default arguments in bridge commands

2 participants