Skip to content

chore(bridge): use BridgeOption instead of Option#2252

Merged
Dorukyum merged 13 commits into
masterfrom
2089-bridge-option
Jan 25, 2024
Merged

chore(bridge): use BridgeOption instead of Option#2252
Dorukyum merged 13 commits into
masterfrom
2089-bridge-option

Conversation

@Middledot

@Middledot Middledot commented Oct 29, 2023

Copy link
Copy Markdown
Member

Summary

Removes "Option" for bridge commands. You should now use BridgeOption

Planned for 2.5

Closes #2089

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested. (I can't seem to build docs right now, but I'll figure it out)
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Middledot
Middledot marked this pull request as ready for review January 16, 2024 04:58
@Middledot
Middledot requested review from a team as code owners January 16, 2024 04:58
Comment thread discord/ext/bridge/core.py Outdated
@Dorukyum

Copy link
Copy Markdown
Member

Changelog entry please

Comment thread docs/ext/bridge/api.rst
@Dorukyum Dorukyum added priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Jan 18, 2024
@Dorukyum Dorukyum closed this Jan 25, 2024
@Dorukyum Dorukyum reopened this Jan 25, 2024
@Dorukyum
Dorukyum merged commit 2731d21 into master Jan 25, 2024
@Dorukyum
Dorukyum deleted the 2089-bridge-option branch January 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent default arguments in bridge commands

2 participants