refactor: python implementation of `audioop.mul` by davidhozic · Pull Request #2176 · Pycord-Development/pycord

davidhozic · 2023-07-23T10:48:46Z

Summary

This PR replaces the PCMVolumeTransformer.read() method with a Python equivalent, that does not use the audioop module, which is deprecated since Python 3.11 and will be removed in Python 3.13.

This implements #2177.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

…nto feat/audioop

VincentRPS

LGTM

OmLanke · 2023-07-27T11:20:55Z

A python equivalent will not be nearly as close as the C one in terms of performance. Live audio is a heavy load and has to be low latency.

VincentRPS · 2023-07-27T11:24:34Z

A python equivalent will not be nearly as close as the C one in terms of performance. Live audio is a heavy load and has to be low latency.

I mean we can always rewrite it in Rust.

VincentRPS · 2023-07-27T11:25:20Z

and also this largely uses python stdlib modules which from the seems of things are written in C in many places.

OmLanke · 2023-07-27T11:33:11Z

A python equivalent will not be nearly as close as the C one in terms of performance. Live audio is a heavy load and has to be low latency.

I mean we can always rewrite it in Rust.

The whole voice stuff could be rewritten to Rust 😬

OmLanke · 2023-07-27T11:33:53Z

and also this largely uses python stdlib modules which from the seems of things are written in C in many places.

Possible to do actual performance tests?

VincentRPS · 2023-07-27T11:39:06Z

A python equivalent will not be nearly as close as the C one in terms of performance. Live audio is a heavy load and has to be low latency.

I mean we can always rewrite it in Rust.

The whole voice stuff could be rewritten to Rust 😬

only if :)

davidhozic · 2023-07-27T17:08:16Z

audioop:

Without audioop:

Hardware:
OS Name Microsoft Windows 10 Pro
Processor AMD Ryzen 5 5600X 6-Core Processor, 3701 Mhz, 6 Core(s), 12 Logical Processor(s)

OmLanke · 2023-07-27T17:16:39Z

Hmm that sure is a difference.

Use time.perf_counter_ns() instead of time.time(). The result will be more accurate and will return ns instead of s

OmLanke · 2023-07-27T17:19:23Z

Can we maintain and ship our own audioop C file? Dpy plans to do something like that

Or we could try Cython or maybe Rust?

Signed-off-by: Lala Sabathil <[email protected]>

davidhozic · 2024-10-07T20:51:06Z

bump

davidhozic · 2024-10-08T13:05:39Z

Btw, that requested change is already resolved, not sure why it doesn't automatically detect it.

Stale

Lulalaby

Where does this come from

Co-authored-by: Lala Sabathil <[email protected]> Signed-off-by: David Hozic <[email protected]>

davidhozic · 2024-10-16T17:33:49Z

Where does this come from

The changelog thing? It was probably added through some weird auto-merge.

…2176) * Replace audioop * style(pre-commit): auto fixes from pre-commit.com hooks * versionchanged * changelog * style(pre-commit): auto fixes from pre-commit.com hooks * speed * style(pre-commit): auto fixes from pre-commit.com hooks * changelog * Optimization (1 ms) * Update discord/player.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: David Hozic <[email protected]> * Update CHANGELOG.md Co-authored-by: Lala Sabathil <[email protected]> Signed-off-by: David Hozic <[email protected]> --------- Signed-off-by: David Hozic <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Lala Sabathil <[email protected]>

davidhozic · 2025-05-04T18:14:42Z

Are there any plans or are the main maintainters open for rewriting some of the audio functionalities in Rust (for performance reasons)?

DA-344 · 2025-05-04T23:11:47Z

Are there any plans or are the main maintainters open for rewriting some of the audio functionalities in Rust (for performance reasons)?

Py-cord is meant to be used in (almost) all machines, and writing Rust implementations will prevent some machines to use it anymore because they cannot compile such code.

davidhozic and others added 6 commits July 23, 2023 12:43

Replace audioop

498e35c

style(pre-commit): auto fixes from pre-commit.com hooks

d82d0d3

versionchanged

9d07e17

changelog

11bfdbc

Merge branch 'feat/audioop' of https://github.com/davidhozic/pycord i…

645cd51

…nto feat/audioop

style(pre-commit): auto fixes from pre-commit.com hooks

fb785c2

davidhozic changed the title ~~feat: Replace deprecated audioop~~ feat: Replace deprecated audioop implementation of PCMVolumeTransformer.read Jul 23, 2023

davidhozic marked this pull request as ready for review July 23, 2023 10:54

davidhozic requested a review from a team as a code owner July 23, 2023 10:54

pullapprove4 Bot requested a review from BobDotCom July 23, 2023 10:54

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Jul 23, 2023

pullapprove4 Bot requested a review from FrostByte266 July 23, 2023 10:54

davidhozic mentioned this pull request Jul 23, 2023

Replace deprecated audioop implementation of PCMVolumeTransformer.read #2177

Closed

Lulalaby added priority: low Low Priority on hold labels Jul 23, 2023

Lulalaby linked an issue Jul 23, 2023 that may be closed by this pull request

Replace deprecated audioop implementation of PCMVolumeTransformer.read #2177

Closed

VincentRPS previously approved these changes Jul 26, 2023

View reviewed changes

pullapprove4 Bot removed the PA: Maintainers pending label Jul 26, 2023

davidhozic dismissed VincentRPS’s stale review via 6a1a901 July 27, 2023 17:24

pullapprove4 Bot added the PA: Maintainers pending label Jul 27, 2023

pullapprove4 Bot added PA: All Contributors pending PA: Maintainers pending labels Jul 8, 2024

Lulalaby modified the milestones: v2.6, v2.7 Jul 9, 2024

Lulalaby and others added 2 commits August 16, 2024 14:53

Merge branch 'master' into feat/audioop

20b3af3

Signed-off-by: Lala Sabathil <[email protected]>

Merge branch 'master' into feat/audioop

e4d5e73

Merge branch 'master' into feat/audioop

1d4c9e5

Merge branch 'master' into feat/audioop

8b4364e

davidhozic requested a review from Lulalaby October 12, 2024 23:49

Paillat-dev mentioned this pull request Oct 15, 2024

chore: add support for Python 3.13 #2609

Merged

Lulalaby requested changes Oct 15, 2024

View reviewed changes

pullapprove4 Bot removed PA: All Contributors pending PA: Maintainers pending labels Oct 15, 2024

Merge branch 'master' into feat/audioop

ba7471b

Lulalaby requested changes Oct 15, 2024

View reviewed changes

Comment thread CHANGELOG.md Outdated

Update CHANGELOG.md

7e91341

Co-authored-by: Lala Sabathil <[email protected]> Signed-off-by: David Hozic <[email protected]>

Lulalaby approved these changes Oct 17, 2024

View reviewed changes

pullapprove4 Bot added the PA: All Contributors pending label Oct 17, 2024

plun1331 approved these changes Oct 17, 2024

View reviewed changes

pullapprove4 Bot removed the PA: All Contributors pending label Oct 17, 2024

plun1331 merged commit 33adf22 into Pycord-Development:master Oct 17, 2024

davidhozic deleted the feat/audioop branch May 4, 2025 18:14

Uh oh!

Uh oh!

Conversation

davidhozic commented Jul 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

VincentRPS left a comment

Choose a reason for hiding this comment

Uh oh!

OmLanke commented Jul 27, 2023

Uh oh!

VincentRPS commented Jul 27, 2023

Uh oh!

VincentRPS commented Jul 27, 2023

Uh oh!

OmLanke commented Jul 27, 2023

Uh oh!

OmLanke commented Jul 27, 2023

Uh oh!

VincentRPS commented Jul 27, 2023

Uh oh!

davidhozic commented Jul 27, 2023

Uh oh!

OmLanke commented Jul 27, 2023

Uh oh!

OmLanke commented Jul 27, 2023

Uh oh!

davidhozic commented Oct 7, 2024

Uh oh!

davidhozic commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lulalaby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidhozic commented Oct 16, 2024

Uh oh!

davidhozic commented May 4, 2025

Uh oh!

DA-344 commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

davidhozic commented Jul 23, 2023 •

edited

Loading

davidhozic commented Oct 8, 2024 •

edited

Loading