feat: add suppress and allowed_mentions parameters#2138
Merged
Conversation
Lulalaby
previously approved these changes
Jun 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 33.88% 33.86% -0.02%
==========================================
Files 109 109
Lines 22343 22360 +17
==========================================
+ Hits 7571 7573 +2
- Misses 14772 14787 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
auto-merge was automatically disabled
June 23, 2023 21:34
Head branch was pushed to by a user without write access
Lulalaby
previously approved these changes
Jun 23, 2023
Lulalaby
enabled auto-merge (squash)
June 23, 2023 22:06
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
approved these changes
Jun 24, 2023
Lulalaby
approved these changes
Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
suppressandallowed_mentionsparameters toInteractionResponse.edit_message.Also adds
suppressparameter for editing messages using webhooks.The
suppress_embedsflag andallowed_mentionsare supported forInteractionResponse.edit_messagehttps://discord.com/developers/docs/interactions/receiving-and-responding#interaction-response-object-messagesThe
suppress_embedsflags is undocumented for editing message by webhooks, but it works.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.