Closed
Conversation
Manually expanding them is unnecessary, and pollutes the source tree.
This makes sure any externally set state is maintained outside the relevant section.
Prevent accidental errors from creeping in later.
Removes the templating step by adding another array to wavelets_coeffs. In the long run the plan is to remove all templating steps from the C part.
free(NULL) and PyMem_Free(NULL) are both no-ops, so no need to check for NULL before. The struct is also immediately free'd after, so setting the filter pointer to NULL also provides no advantage.
This is the last of it! Actually comes in at slightly shorter than before.
Member
Author
|
Closed in favor of #161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the last bit of
.srctemplating from the C sources. It actually comes in slightly shorter, and as a bonus means we are no longer tied to numpy-specific distutils. I've done that work already in the process of sorting out ASV, even though it turned out not to be necessary, so I'll open a PR for discussion of that once this is merged.