-
Notifications
You must be signed in to change notification settings - Fork 55
Organic Rankine Cycle Data #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d762f67
added organic rankine cycle, moved some data from EGS
LukasFrankenQ 6ed3e41
specified type of power
LukasFrankenQ 70ddb81
fixed type in PR template
LukasFrankenQ a02cd60
moved geothermal, orc to manual_input.csv
LukasFrankenQ 19f96b6
round values in manual input as integers
LukasFrankenQ d025178
Merge https://github.com/pypsa/technology-data
LukasFrankenQ a17df91
Merge https://github.com/pypsa/technology-data
LukasFrankenQ 54cbf32
changed efficiency description and cost labeling + currency of ORC
LukasFrankenQ 2b800ad
Merge https://github.com/pypsa/technology-data
LukasFrankenQ e3cf0a3
included new round of feedback
LukasFrankenQ f7b4022
updated output files
LukasFrankenQ 4b25dc3
merged with upstream
LukasFrankenQ 3901bae
Merge https://github.com/pypsa/technology-data
LukasFrankenQ 000fdb7
updated outputs
LukasFrankenQ b281026
Merge branch 'master' into master
fneum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Shouldn't heat input vs. heat output be > 1?
Based on the previous 0.8 efficiency value like: 1 / 0.8 = 1.25 ?
if not, maybe I'm misunderstanding the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where the intuition is coming from, but I was convinced otherwise, and feel confident in 80% 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... I guess? It doesn't make any sense to me and the description in the file isn't explaining it. Would you care to indulge me? Or should I just accept and be quiet? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya @euronion, sorry for missing this and for going 'dude, trust me.'
I hope I get this right, but I think your intuition is summarized as such:
Say we have
Q_inwith temperature 150 degreesC, and it meets demandQ_outwith a temperature of 90 degrees, then shouldnt that happen at an efficiency of > 1.. Is that the intuition? Otherwise we are talking about different things.What this intuition misses is that the temperature is already priced into the power (roughly mass flow times temperature). So when thinking about situation where
Q_in = Q_out, but they have a 60 degreeC temperature difference what we are really talking about is the hotter flow having a much smaller mass flow and us mixing in cooler liquid to accommodate the properties required atQ_out... Does that help? Maybe it wasnt the problem, does not feel very complex but mass flow is what was missing in my intuition.