Conversation
euronion
left a comment
euronion
left a comment
There was a problem hiding this comment.
Cool!
- Why the changes to
offwind-float-*technologies in theoutputs/files? - Since your entering the data manually, would you mind moving it into
input/manual_input.csv? Leads to less code bloating and is easier to use/track. (Maybe also the geothermal assumptions?) - You removed the
efficiency electricityfromgeothermal, but this change is not represented in the output files. Do the output files need to be recreated or is there a bug somewhere? - Removing the
geothermalefficiency electricityshould also be noted in the release notes ;-)
|
Many thanks for the review @euronion, will amend! |
|
Hey @euronion, I moved everything to ... EXCEPT the changes in offshore wind, which I frankly do not understand - clearly nothing in relation to that is changed in the code. I have double checked my What do you propose? |
|
Thanks @LukasFrankenQ ! Regarding Can you also remove the clutter in |
|
Alright, should be all set, thanks for research with regards to the wind. There seems to be a new issue here, should this be adjusted? Seems less straightforward which version is better... |
|
Thanks! Much easier to review now :) |
|
Hey @euronion, I made the suggested changes, sorry for the delay! Let me know what you think :) |
euronion
left a comment
euronion
left a comment
There was a problem hiding this comment.
We're getting there :)
| geothermal,CO2 intensity,2020,0.12,tCO2/MWh_el,2020,"Aghahosseini, Breyer 2020: From hot rock to useful energy: A global estimate of enhanced geothermal systems potential, https://www.sciencedirect.com/science/article/pii/S0306261920312551",Likely to be improved; Average of 85 percent of global egs power plant capacity; Result of fluid circulation through rock formations | ||
| geothermal,lifetime,2020,30,years,2020,"Aghahosseini, Breyer 2020: From hot rock to useful energy: A global estimate of enhanced geothermal systems potential, https://www.sciencedirect.com/science/article/pii/S0306261920312551", | ||
| geothermal,efficiency central heat,2020,0.8,per unit,2020,"Aghahosseini, Breyer 2020: From hot rock to useful energy: A global estimate of enhanced geothermal systems potential, https://www.sciencedirect.com/science/article/pii/S0306261920312551; Breede et al. 2015: Overcoming challenges in the classification of deep geothermal potential, https://eprints.gla.ac.uk/169585/","This is a rough estimate, depends on local conditions" | ||
| geothermal,district heat-input,2020,0.8,MWh_thdh/MWh_th,2020,"Aghahosseini, Breyer 2020: From hot rock to useful energy: A global estimate of enhanced geothermal systems potential, https://www.sciencedirect.com/science/article/pii/S0306261920312551; Breede et al. 2015: Overcoming challenges in the classification of deep geothermal potential, https://eprints.gla.ac.uk/169585/","Heat-input, District Heat-output. This is an assessment of typical heat losses when heat is transmitted from the EGS plant to the DH network, This is a rough estimate, depends on local conditions" |
There was a problem hiding this comment.
Question: Shouldn't heat input vs. heat output be > 1?
Based on the previous 0.8 efficiency value like: 1 / 0.8 = 1.25 ?
if not, maybe I'm misunderstanding the value.
There was a problem hiding this comment.
I see where the intuition is coming from, but I was convinced otherwise, and feel confident in 80% 👍
There was a problem hiding this comment.
Ok... I guess? It doesn't make any sense to me and the description in the file isn't explaining it. Would you care to indulge me? Or should I just accept and be quiet? ;-)
There was a problem hiding this comment.
Heya @euronion, sorry for missing this and for going 'dude, trust me.'
I hope I get this right, but I think your intuition is summarized as such:
Say we have Q_in with temperature 150 degreesC, and it meets demand Q_out with a temperature of 90 degrees, then shouldnt that happen at an efficiency of > 1.. Is that the intuition? Otherwise we are talking about different things.
What this intuition misses is that the temperature is already priced into the power (roughly mass flow times temperature). So when thinking about situation where Q_in = Q_out, but they have a 60 degreeC temperature difference what we are really talking about is the hotter flow having a much smaller mass flow and us mixing in cooler liquid to accommodate the properties required at Q_out... Does that help? Maybe it wasnt the problem, does not feel very complex but mass flow is what was missing in my intuition.
|
Hi @euronion, apologies for the delay, worked in the feedback! Let me know if there is anything else 🙌 |
3 participants
Adds data for Organic Rankine Cycles (ORC), and moves some data previously assigned to Enhanced Geothermal to ORC, to make things more clear.
Potentially has some overlap with data on waste or biomass, but the literature suggests this type of ORC operating around ~150 C is mostly used in a geothermal context, so it appears to warrant a separate technology. The implicit assumption of operating temperatures is stated clearly.
Also fixes a typo in the PR template.
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.