Skip to content

Fix grouping year reference in add_land_use_constraint_m#991

Merged
fneum merged 1 commit intoPyPSA:masterfrom
Climact:feature/fix-grouping-years-reference
Apr 3, 2024
Merged

Fix grouping year reference in add_land_use_constraint_m#991
fneum merged 1 commit intoPyPSA:masterfrom
Climact:feature/fix-grouping-years-reference

Conversation

@tgi-climact
Copy link
Copy Markdown
Contributor

Fix grouping year reference from grouping_years to grouping_years_power in add_land_use_constraint_m.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@tgi-climact
Copy link
Copy Markdown
Contributor Author

@fneum Could be usefull to add to tests a scenario with m option for clusters (https://github.com/PyPSA/pypsa-eur/blob/master/config/test/config.myopic.yaml#L19). What do you think about it ?

@FabianHofmann
Copy link
Copy Markdown
Contributor

FabianHofmann commented Mar 26, 2024

@fneum Could be usefull to add to tests a scenario with m option for clusters (https://github.com/PyPSA/pypsa-eur/blob/master/config/test/config.myopic.yaml#L19). What do you think about it ?

that is probably a good idea, however we have to keep in mind to not bloat the CI resources/time
EDIT: If you want to propose something, that's most welcome

@FabianHofmann FabianHofmann enabled auto-merge March 26, 2024 12:10
@fneum fneum disabled auto-merge April 3, 2024 09:38
@fneum fneum merged commit a777872 into PyPSA:master Apr 3, 2024
@tgi-climact tgi-climact deleted the feature/fix-grouping-years-reference branch May 21, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants