Merged
Conversation
added 3 commits
March 19, 2024 08:54
First, cannot cast pd index to boolean. Second, fix logic error of mistakenly swapped difference in calculating missing years.
Preventing problems when parallel processes attempt to move the same file to different resources directories.
Contributor
Author
|
If you will allow me, I tacked one more one-line bugfix to this PR; the natura.tiff file needs to be copied to resources instead of moved since otherwise multiple processes can try to move the same file away, and all but one will fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really do try to test my PRs, but somehow two typos slipped through in the most recent ones; I'm sorry! Here is the fix.
To make up for it I found and fixed a mistake in the logic of filling in missing years of total hydro production data. I've tested this and it works :) Used to throw an error (cannot cast Series to boolean) but also the calculation of which years were missing was the wrong way around.
Hope it's fine it package these two fixes in one PR just to avoid overrunning you with PRs.
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.