Fill in missing eurostat data on domestic aviation energy demand#973
Merged
fneum merged 2 commits intoPyPSA:masterfrom Mar 21, 2024
Merged
Fill in missing eurostat data on domestic aviation energy demand#973fneum merged 2 commits intoPyPSA:masterfrom
fneum merged 2 commits intoPyPSA:masterfrom
Conversation
koen-vg
force-pushed
the
fill-missing-domestic-aviation
branch
from
f432fd3 to
a8454fd
Compare
fneum
approved these changes
Mar 21, 2024
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
Thanks! Great catch, great fix!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This fixes a nasty bug where
rescale_idees_from_eurostatwould result in infinite kerosene demand upon division by zero (obviously leading to infeasibility of the model, but no earlier error). I think filling in zeroes this way seems like the most reasonable way of dealing with the problem, but not 100% sure. At least it does work now.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.