Conversation
Contributor
|
@toniseibold great! Just a few remarks:
|
Contributor
FabianHofmann
left a comment
There was a problem hiding this comment.
just some stylistic comments
Contributor
I think, a separate rule |
Contributor
|
@toniseibold |
fneum
approved these changes
Mar 5, 2024
Member
|
Checked output of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Reads in the latest eurostat report from 2023 and uses it for building energy totals.
Since the JRC IDEES data is only available for 2015, the energy balances are scaled by the factor of eurostat[report_year]/eurostat[2015] data as well.
The latest swiss energy totals are added to ensure consistent energy totals.
To complement the PR, please add the eurostat data from 2023 to the zenodo data.
Missing is only the passenger car efficiency and the number of passenger cars that are initially in the JRC IDEES but not in the eurostat data set.
Comparison between 2023 and 2016 reports for the year 2013 show no difference except for Norway and Switzerland.
energy_totals_comparison.csv
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.