Miscellaneous perfect foresight fixes#910
Merged
fneum merged 7 commits intoPyPSA:masterfrom Feb 5, 2024
Merged
Conversation
added 5 commits
February 2, 2024 08:49
Previously, time-varying data in each "next" investment period was set to the default values, implying capacity factors of 1 for renewable generators for example.
Member
|
Thanks, this is super helpful! I agree about the tests. |
fneum
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This is just a collection of a few unrelated but minor commits I've made on way to making perfect foresight optimisations work. It's still experimental and I can't guarantee that there aren't any issues remaining but these seem like some obvious fixes at least.
On a vaguely related note, I guess it would be good idea to write some decent tests for perfect foresight runs.
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.