prepare_sector_network: reorder buses for dac components#901
Merged
Conversation
fneum
requested changes
Jan 26, 2024
Member
fneum
left a comment
There was a problem hiding this comment.
I think there is one mistake with the units / efficiencies. Could you double check?
Contributor
Author
|
I made a small test case locally, this works as expected. |
fneum
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the order of buses (bus0, bus1, ...) for DAC components to meet the convention of the other components:
bus0refers to the electricity bus (input),bus1to the heat bus (input), 'bus2' to the CO2 atmosphere bus (input), andbus3to the CO2 storage bus (output).Why is this helpful?
For many routines in the pypsa statistics module, a convention where the
bus0points to the location (in order to extract local balances) is assumed. With this change, the location of the DAC facilities is properly processed.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.