Don't include triple solar potential option by default#891
Merged
fneum merged 1 commit intoPyPSA:masterfrom Jan 24, 2024
Merged
Don't include triple solar potential option by default#891fneum merged 1 commit intoPyPSA:masterfrom
fneum merged 1 commit intoPyPSA:masterfrom
Conversation
Member
|
Agreed, I missed this. Thanks! |
Contributor
Author
|
Actually I do now see that this was maybe a bit rushed and there are more references to |
Member
|
I can do it, no worries |
fneum
added a commit
that referenced
this pull request
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
A trivial change in default
{sector_opts}wildcard. I know that it's very much the intention that users will inform themselves about each wildcard and option and change them to fit their needs. However, defaults do carry some weight, and arguably thesolar+p3option was a sensible default. After a0f43ae, however, this is no longer the case! I would remove the option from the default{sector_opts}wildcard to avoid confusion.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.