Skip to content

group storage with duplicate labels#873

Merged
fneum merged 4 commits intomasterfrom
duplicate-labels-H2-storage
Jan 18, 2024
Merged

group storage with duplicate labels#873
fneum merged 4 commits intomasterfrom
duplicate-labels-H2-storage

Conversation

@lindnemi
Copy link
Copy Markdown
Contributor

@lindnemi lindnemi commented Jan 17, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

fixes an error that occurs when h2 storage is built at the same bus but at different snapshots

Traceback (most recent call last):
  File "/home/micha/git/pypsa-ariadne/.snakemake/scripts/tmp53wos82s.plot_network.py", line 1105, in <module>
    plot_h2_map(n, regions)
  File "/home/micha/git/pypsa-ariadne/.snakemake/scripts/tmp53wos82s.plot_network.py", line 278, in plot_h2_map
    regions["H2"] = h2_storage.rename(
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/geopandas/geodataframe.py", line 1543, in __setitem__
    super().__setitem__(key, value)
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/frame.py", line 4091, in __setitem__
    self._set_item(key, value)
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/frame.py", line 4300, in _set_item
    value, refs = self._sanitize_column(value)
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/frame.py", line 5036, in _sanitize_column
    return _reindex_for_setitem(value, self.index)
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/frame.py", line 12309, in _reindex_for_setitem
    raise err
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/frame.py", line 12304, in _reindex_for_setitem
    reindexed_value = value.reindex(index)._values
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/series.py", line 4981, in reindex
    return super().reindex(
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/generic.py", line 5521, in reindex
    return self._reindex_axes(
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/generic.py", line 5544, in _reindex_axes
    new_index, indexer = ax.reindex(
  File "/home/micha/micromamba/envs/pypsa-ariadne/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 4434, in reindex
    raise ValueError("cannot reindex on an axis with duplicate labels")
ValueError: cannot reindex on an axis with duplicate labels

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lindnemi lindnemi requested a review from fneum January 17, 2024 16:10
FabianHofmann
FabianHofmann reviewed Jan 17, 2024
View reviewed changes
scripts/plot_network.py Outdated
Comment on lines +1072 to +1075
clusters="22",
ll="v1.2",
sector_opts="365H-T-H-B-I-A-solar+p3-linemaxext15",
planning_horizons="2040",
Copy link
Copy Markdown
Contributor

@FabianHofmann FabianHofmann Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove these changes?

Copy link
Copy Markdown
Contributor Author

@lindnemi lindnemi Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot, that was an accident!

@fneum
Copy link
Copy Markdown
Member

fneum commented Jan 18, 2024

Looks good and also works for overnight scenarios.

@fneum fneum merged commit 948bf3b into master Jan 18, 2024
@fneum fneum deleted the duplicate-labels-H2-storage branch January 18, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianHofmann FabianHofmann FabianHofmann left review comments

@fneum fneum fneum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lindnemi @fneum @FabianHofmann