Add warning when negative bev availability profile values#858
Merged
fneum merged 1 commit intoPyPSA:masterfrom Jan 17, 2024
Merged
Add warning when negative bev availability profile values#858fneum merged 1 commit intoPyPSA:masterfrom
fneum merged 1 commit intoPyPSA:masterfrom
Conversation
Member
|
It would be good to understand where the negative values could come from and fix the underlying issue. |
Contributor
Author
In my case, I was defining a too high value for Because it's configuration based, I'm afraid there's not that much to do other than raise a warning. |
fneum
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Changing the
bev_avail_maxandbev_avail_meanvalues could cause the profile to generate negative values. This leads to infeasibility. Raising a warning earlier in the process is useful to catch the configuration error sooner. This warning is raised inbuild_transport_demand.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.