Skip to content

Implement everywhere_powerplants#850

Merged
fneum merged 11 commits intomasterfrom
feat/carriers-everywhere
Jan 8, 2024
Merged

Implement everywhere_powerplants#850
fneum merged 11 commits intomasterfrom
feat/carriers-everywhere

Conversation

@euronion
Copy link
Copy Markdown
Contributor

@euronion euronion commented Jan 8, 2024

Changes proposed in this Pull Request

The combination of conventional_carriers and extendable_carriers currently only allows for expanding conventional capacities in locations, where historically powerplants of that carrier where located.
This PR adds a new configuration option to place conventional powerplants at every network node, irrespective whether powerplants have historically existed there.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • [n/a] Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@euronion
Copy link
Copy Markdown
Contributor Author

euronion commented Jan 8, 2024

Not sure why the environment.fixed.yaml got reformatted automatically by pre-commit

@euronion euronion requested a review from fneum January 8, 2024 08:43
fneum
fneum approved these changes Jan 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely documented :)

fneum
fneum reviewed Jan 8, 2024
View reviewed changes
@euronion
Copy link
Copy Markdown
Contributor Author

euronion commented Jan 8, 2024

These errors are what I get for changing the variable names last minute ._.

@euronion
Copy link
Copy Markdown
Contributor Author

euronion commented Jan 8, 2024

Btw.: Reformatting of environment.fixed.yaml and missing REUSE compliance of the file related bf5c323 because it was pushed directly. Fixing it here.

@fneum
Copy link
Copy Markdown
Member

fneum commented Jan 8, 2024

Hmm, gibt noch einige Probleme:

 Traceback (most recent call last):
  File "/home/runner/work/pypsa-eur/pypsa-eur/.snakemake/scripts/tmp9uspklvi.add_existing_baseyear.py", line 678, in <module>
    add_power_capacities_installed_before_baseyear(
  File "/home/runner/work/pypsa-eur/pypsa-eur/.snakemake/scripts/tmp9uspklvi.add_existing_baseyear.py", line 199, in add_power_capacities_installed_before_baseyear
    df_agg["grouping_year"] = np.take(
                              ^^^^^^^^
  File "/home/runner/micromamba/envs/pypsa-eur/lib/python3.11/site-packages/numpy/core/fromnumeric.py", line 192, in take
    return _wrapfunc(a, 'take', indices, axis=axis, out=out, mode=mode)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/pypsa-eur/lib/python3.11/site-packages/numpy/core/fromnumeric.py", line 56, in _wrapfunc
    return _wrapit(obj, method, *args, **kwds)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/pypsa-eur/lib/python3.11/site-packages/numpy/core/fromnumeric.py", line 45, in _wrapit
    result = getattr(asarray(obj), method)(*args, **kwds)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
IndexError: index 11 is out of bounds for axis 0 with size 11

@fneum fneum merged commit 799ed06 into master Jan 8, 2024
@fneum fneum deleted the feat/carriers-everywhere branch January 8, 2024 15:45
@euronion
Copy link
Copy Markdown
Contributor Author

euronion commented Jan 8, 2024

Thanks! :)

euronion pushed a commit to aodenweller/pypsa-eur that referenced this pull request Jan 8, 2024
@fneum @euronion
Merge pull request PyPSA#850 from PyPSA/feat/carriers-everywhere
14f3d97 
Implement everywhere_powerplants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@euronion @fneum