Conversation
fneum
approved these changes
Dec 4, 2023
Member
fneum
left a comment
There was a problem hiding this comment.
LGTM, just one stylistic comment.
Co-authored-by: Fabian Neumann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Add a vent for district heating
This PR should add a vent for district heating. Currently, with the must run condition for Fischer-Tropsch synthesis, waste heat usage enabled and decreasing heating demand (as assumed exogenously in the config default setting), pathway optimisation leads to infeasibilities in some investment periods since large Fischer-Tropsch capacities are needed in early years but the waste heat exceeds the heat demand in later investment periods.
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.