Merged
Conversation
martacki
requested changes
Oct 30, 2023
Member
martacki
left a comment
martacki
left a comment
There was a problem hiding this comment.
With the currently suggested changes, the script cannot be compiled on Linux. We're working on a fix.
Contributor
Author
|
Hello, @martacki. I have added encoding based on the OS. For Windows it is |
martacki
approved these changes
Apr 23, 2024
Member
martacki
left a comment
martacki
left a comment
There was a problem hiding this comment.
Tested on Linux, seems to run.
The script is furthermore not touched with the default config configuration, only when biomass_transport = True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Good day. Here I propose changes to
build_biomass_transport_costs.pyfile to fix the error that happens whenbiomass_transportis set true in the config. I have uploaded the error. It is related to utf-8 encoding, in particular, the error happens due to EUR sign. I run my code in the windows machine. The error is resolved by explicitly defining encoding ascp1252which is a windows compatible encoding and an extension oflatin-1encoding. After I have fixed the code, I have checked the resulting csv. The resulting biomass transport costs coincides with the supplementary material in Liza's paper on "Mitigating heat demand ...".Checklist
doc/release_notes.rstis added.