Conversation
use copy config for all solve rules remove copying of environment
fneum
approved these changes
Aug 2, 2023
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
LGTM. We could think of adding a commit-hash to n.meta, like abcd1234-dirty to follow version of preparation and solving scripts.
Contributor
Author
Indeed, and since we are storing the config in the network meta anyway, should we just get rid of the copy config for good? |
Member
|
Hmm, you're right that there's some duplication but maybe a YAML is easier to inspect ad-hoc. |
Contributor
|
I would favor keeping the .yaml file. It is also useful if you want to use it for a summary script of all scenarios since you do not have to read in a pypsa network to check the n.meta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only copy active configuration to results folder
use copy config for all solve rules
remove copying of environment
Changes proposed in this Pull Request
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.