Conversation
auto-merge was automatically disabled
July 25, 2023 15:13
Pull request was closed
Contributor
|
@fneum did you close intentionally? was lgtm |
Member
Author
|
Ups. No, but tests did not pass. |
Collaborator
|
@fneum after the implementation of this change we ran into another issue in PyPSA-Earth described here pypsa-meets-earth/pypsa-earth#774 and solved here: pypsa-meets-earth/pypsa-earth#797. Without looking into further detail here, I guess we should integrate the solution in pypsa-meets-earth/pypsa-earth#797 in PyPSA-Eur as well. What do you think? Happy to add it to this PR. |
Member
Author
|
@energyLS Thanks for letting me know! Saved me some time going bug hunting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676