Skip to content

no more override_component_attrs for multilinks#695

Merged
fneum merged 10 commits intomasterfrom
multilinks-default
Jul 26, 2023
Merged

no more override_component_attrs for multilinks#695
fneum merged 10 commits intomasterfrom
multilinks-default

Conversation

@fneum
Copy link
Copy Markdown
Member

@fneum fneum commented Jul 13, 2023 •
edited
Loading

Requires PyPSA master (to be v0.25.1)

FabianHofmann
FabianHofmann approved these changes Jul 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@fneum
Copy link
Copy Markdown
Member Author

fneum commented Jul 25, 2023

Hmm, I think I have to have another look.

Traceback (most recent call last):
  File "/home/runner/work/pypsa-eur/pypsa-eur/.snakemake/scripts/tmp0xfcjq8f.make_summary.py", line 709, in <module>
    df = make_summaries(networks_dict)
  File "/home/runner/work/pypsa-eur/pypsa-eur/.snakemake/scripts/tmp0xfcjq8f.make_summary.py", line 671, in make_summaries
    df[output] = globals()["calculate_" + output](n, label, df[output])
  File "/home/runner/work/pypsa-eur/pypsa-eur/.snakemake/scripts/tmp0xfcjq8f.make_summary.py", line 306, in calculate_energy
    totals.loc[no_bus] = n.component_attrs[c.name].loc[
  File "/home/runner/micromamba/envs/pypsa-eur/lib/python3.10/site-packages/pandas/core/indexing.py", line 1096, in __getitem__
    return self.obj._get_value(*key, takeable=self._takeable)
  File "/home/runner/micromamba/envs/pypsa-eur/lib/python3.10/site-packages/pandas/core/frame.py", line 3877, in _get_value
    row = self.index.get_loc(index)
  File "/home/runner/micromamba/envs/pypsa-eur/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 3655, in get_loc
    raise KeyError(key) from err
KeyError: 'p2'

@FabianHofmann
Copy link
Copy Markdown
Contributor

FabianHofmann commented Jul 25, 2023

probably a calculate_dependent_values() in advance should do it?

@fneum fneum marked this pull request as ready for review July 26, 2023 06:48
@fneum fneum enabled auto-merge July 26, 2023 06:49
@fneum fneum merged commit 799f4f3 into master Jul 26, 2023
@fneum fneum deleted the multilinks-default branch July 26, 2023 07:14
@virio-andreyana virio-andreyana mentioned this pull request Mar 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianHofmann FabianHofmann FabianHofmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fneum @FabianHofmann