Complete carrier set by virio-andreyana · Pull Request #653 · PyPSA/pypsa-eur

virio-andreyana · 2023-04-25T15:26:07Z

Closes #633

Changes proposed in this Pull Request

add the function add_missing_carrier in add_electricity in order to ensure complete set of carriers mentioned in issue #633 . The function is copied in

add_extra_components.py
add_existing_baseyear.py
add_extra_component.py
prepare_sector_network.py

Checklist

I tested my contribution locally and it seems to work fine.
Code and workflow changes are sufficiently documented.
Changes in configuration options are also documented in doc/configtables/*.csv.
A release note doc/release_notes.rst is added.

Note: - battery charger and battery discharger has no nice name nor plot_color - H2 electrolysis is similar to H2 Electrolysis in the tech_color - H2 fuel cell is similar to H2 Fuel cell in the tech_color - H2 pipeline do have have nice name and tech_color, but the addition of it depends on the link being true in config

add_missing_carrier() are applied on python script where new components are added. The function runs ideally after all of the new components are added and before add_nice_carrier_names()

for more information, see https://pre-commit.ci

FabianHofmann

Great, thanks @virio-andreyana. Did we say we want to add the carrier colors and nice names in this PR as well?

scripts/add_electricity.py

Co-authored-by: Fabian Hofmann <[email protected]>

virio-andreyana · 2023-04-27T15:40:46Z

Great, thanks @virio-andreyana. Did we say we want to add the carrier colors and nice names in this PR as well?

we can:

embed the function add_nice_carrier_names(n, config) within add_missing_carrier(n)
always run add_nice_carrier_names after add_missing_carrier
merge add_nice_carrier_names with add_missing_carrier to become add_missing_carrier_with_nice_names(n, config)

The third choice looks cleaner, I.ll do that

…issing_carrier_with_nice_names(n, config)

for more information, see https://pre-commit.ci

FabianHofmann · 2023-05-05T06:59:29Z

Hey @virio-andreyana

little things remaining:

WARNING:add_electricity:tech_colors for carriers ['DC', 'H2 electrolysis', 'H2 fuel cell'] not defined in config.
WARNING:add_electricity:tech_colors for carriers ['residential rural oil boiler', 'services rural oil boiler', 'residential urban decentral oil boiler', 'urban central oil boiler', 'services urban decentral oil boiler'] not defined in config.

and could you add a release note?

virio-andreyana · 2023-05-05T09:38:56Z

release note

@FabianHofmann, in the release_notes.rst should I put the changes in PyPSA-Eur 0.8.0 (18th March 2023) or in a newer version?

FabianHofmann · 2023-05-05T09:50:40Z

release note

@FabianHofmann, in the release_notes.rst should I put the changes in PyPSA-Eur 0.8.0 (18th March 2023) or in a newer version?

in "Upcoming Release" https://github.com/PyPSA/pypsa-eur/blob/master/doc/release_notes.rst

for more information, see https://pre-commit.ci

FabianHofmann · 2023-05-05T11:24:42Z

great thanks @virio-andreyana

fneum

Looks good. Just two points I noticed.

scripts/add_extra_components.py

for more information, see https://pre-commit.ci

scripts/add_electricity.py

scripts/add_extra_components.py

for more information, see https://pre-commit.ci

virio-andreyana and others added 7 commits April 24, 2023 05:05

Add carrier "AC" and "DC" in base_network.py

ad9a675

add the function add_missing_carrier

71c1a7f

add_missing_carrier() are applied on python script where new components are added. The function runs ideally after all of the new components are added and before add_nice_carrier_names()

Update add_existing_baseyear.py

56b6718

Update add_extra_components.py

d9f9d48

Update prepare_sector_network.py

756a814

[pre-commit.ci] auto fixes from pre-commit.com hooks

74e9d56

for more information, see https://pre-commit.ci

virio-andreyana marked this pull request as draft April 25, 2023 22:46

virio-andreyana added 2 commits April 26, 2023 04:28

fix bug in prepare_network.py

df38eda

Merge branch 'master' into complete-carrier-set

e38a0a9

virio-andreyana marked this pull request as ready for review April 27, 2023 07:23

FabianHofmann requested changes Apr 27, 2023

View reviewed changes

scripts/add_electricity.py Outdated Show resolved Hide resolved

Update scripts/add_electricity.py

e24ca89

Co-authored-by: Fabian Hofmann <[email protected]>

virio-andreyana and others added 6 commits April 28, 2023 03:43

merge add_nice_carrier_names with add_missing_carrier to become add_m…

72b75fd

…issing_carrier_with_nice_names(n, config)

[pre-commit.ci] auto fixes from pre-commit.com hooks

699a4bd

for more information, see https://pre-commit.ci

use sanitize_carriers to harmonize carrier adjustments

4e8bbd6

add_extra_components: revert carrier addition

13b4327

Merge branch 'master' into complete-carrier-set

de16f19

add tech_colors for previously missing carrier

a28f2c1

fixed little things remaining

5603951

virio-andreyana and others added 2 commits May 5, 2023 12:16

Update release_notes.rst

f6597f4

[pre-commit.ci] auto fixes from pre-commit.com hooks

b5f5b35

for more information, see https://pre-commit.ci

FabianHofmann approved these changes May 5, 2023

View reviewed changes

fneum requested changes May 12, 2023

View reviewed changes

scripts/add_extra_components.py Show resolved Hide resolved

scripts/add_extra_components.py Outdated Show resolved Hide resolved

Merge branch 'master' into complete-carrier-set

824e6bb

pre-commit-ci bot and others added 2 commits May 15, 2023 13:02

[pre-commit.ci] auto fixes from pre-commit.com hooks

e431a96

for more information, see https://pre-commit.ci

Merge branch 'master' into complete-carrier-set

ab09635

FabianHofmann approved these changes Jun 21, 2023

View reviewed changes

scripts/add_electricity.py Outdated Show resolved Hide resolved

scripts/add_electricity.py Outdated Show resolved Hide resolved

scripts/add_extra_components.py Outdated Show resolved Hide resolved

FabianHofmann and others added 6 commits June 29, 2023 16:00

Merge branch 'master' into complete-carrier-set

86c4896

Update scripts/add_extra_components.py

8c7c586

Update scripts/add_electricity.py

cf06204

[pre-commit.ci] auto fixes from pre-commit.com hooks

a9b0d34

for more information, see https://pre-commit.ci

Update scripts/add_electricity.py

3f946dd

[pre-commit.ci] auto fixes from pre-commit.com hooks

d84c7eb

for more information, see https://pre-commit.ci

FabianHofmann enabled auto-merge June 29, 2023 14:11

Merge branch 'master' into complete-carrier-set

e2270ea

FabianHofmann merged commit 89ffa87 into master Jun 29, 2023

FabianHofmann deleted the complete-carrier-set branch June 29, 2023 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete carrier set#653

Complete carrier set#653
FabianHofmann merged 29 commits intomasterfrom
complete-carrier-set

virio-andreyana commented Apr 25, 2023 •

edited

Loading

Uh oh!

FabianHofmann left a comment

Uh oh!

Uh oh!

virio-andreyana commented Apr 27, 2023 •

edited

Loading

Uh oh!

FabianHofmann commented May 5, 2023

Uh oh!

virio-andreyana commented May 5, 2023 •

edited

Loading

Uh oh!

FabianHofmann commented May 5, 2023 •

edited

Loading

Uh oh!

FabianHofmann commented May 5, 2023

Uh oh!

fneum left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

virio-andreyana commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request

Checklist

Uh oh!

FabianHofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

virio-andreyana commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FabianHofmann commented May 5, 2023

Uh oh!

virio-andreyana commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FabianHofmann commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FabianHofmann commented May 5, 2023

Uh oh!

fneum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

virio-andreyana commented Apr 25, 2023 •

edited

Loading

virio-andreyana commented Apr 27, 2023 •

edited

Loading

virio-andreyana commented May 5, 2023 •

edited

Loading

FabianHofmann commented May 5, 2023 •

edited

Loading